-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Travis CI (no longer free) to Github Actions #302
Open
FlipEverything
wants to merge
13
commits into
spotorm:master
Choose a base branch
from
FlipEverything:github-workflows-patch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move from Travis CI (no longer free) to Github Actions #302
FlipEverything
wants to merge
13
commits into
spotorm:master
from
FlipEverything:github-workflows-patch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
@vlucas I don't know what is your plan with this project but I still have an active project that uses spot2 under the hood and I would like to add support (and tests) for PHP 7.4 at least. I created new Github Actions config that mirrors the original config as nearly as possible. Some things to consider:
If this PR is merged we can step forward and add support for higher PHP versions. |
@vlucas ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: Travis is no longer free for open-source projects
I am mimicking the old Travis CI workflow with GitHub Actions as best as possible.
Dependencies:
SPOT_DB_PASSWORD
Changes compared to the old Travis config:
HHVM
- I think we should drop the HHVM support Travis build fixes (PHP 7.1, HHVM) #271 (comment)7.1
- to turn the tests green, some minor modifications are required like this PR: Travis build fixes (PHP 7.1, HHVM) #271