Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum statistics #1661

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Sum statistics #1661

wants to merge 3 commits into from

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 12, 2024

@gatesn gatesn added the benchmark Run benchmarks on this branch label Dec 12, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Dec 12, 2024
github-actions[bot]
github-actions bot reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPC-H

Benchmark suite Current: 2bd7aa1 Previous: 8245062 Ratio
tpch_q01/arrow 529582008 ns 524466983 ns 1.01
tpch_q01/vortex-file-compressed 461227162 ns 449544154 ns 1.03
tpch_q02/arrow 129734778 ns 141066043 ns 0.92
tpch_q02/vortex-file-compressed 126526911 ns 145033785 ns 0.87
tpch_q03/arrow 152339724 ns 167582588 ns 0.91
tpch_q03/vortex-file-compressed 212496769 ns 226642678 ns 0.94
tpch_q04/arrow 173491949 ns 177455894 ns 0.98
tpch_q04/vortex-file-compressed 152395756 ns 160320459 ns 0.95
tpch_q05/arrow 300220309 ns 318364738 ns 0.94
tpch_q05/vortex-file-compressed 321403553 ns 345582588 ns 0.93
tpch_q06/arrow 24649437 ns 25262519 ns 0.98
tpch_q06/vortex-file-compressed 56811229 ns 64806904 ns 0.88
tpch_q07/arrow 574688998 ns 620161909 ns 0.93
tpch_q07/vortex-file-compressed 611992385 ns 637967794 ns 0.96
tpch_q08/arrow 246711097 ns 258887307 ns 0.95
tpch_q08/vortex-file-compressed 305217649 ns 325379834 ns 0.94
tpch_q09/arrow 432302683 ns 468260438 ns 0.92
tpch_q09/vortex-file-compressed 513723467 ns 552255025 ns 0.93
tpch_q10/arrow 250043086 ns 263785297 ns 0.95
tpch_q10/vortex-file-compressed 256381890 ns 275368116 ns 0.93
tpch_q11/arrow 127265154 ns 141166179 ns 0.90
tpch_q11/vortex-file-compressed 113592111 ns 124953690 ns 0.91
tpch_q12/arrow 176683033 ns 178715166 ns 0.99
tpch_q12/vortex-file-compressed 213096696 ns 224681282 ns 0.95
tpch_q13/arrow 162755387 ns 166095325 ns 0.98
tpch_q13/vortex-file-compressed 170885938 ns 179818511 ns 0.95
tpch_q14/arrow 33891907 ns 36622517 ns 0.93
tpch_q14/vortex-file-compressed 61037237 ns 63921648 ns 0.95
tpch_q15/arrow 65356363 ns 67686385 ns 0.97
tpch_q15/vortex-file-compressed 98984439 ns 104890409 ns 0.94
tpch_q16/arrow 87598460 ns 104102139 ns 0.84
tpch_q16/vortex-file-compressed 88450055 ns 107946395 ns 0.82
tpch_q17/arrow 581795767 ns 595055767 ns 0.98
tpch_q17/vortex-file-compressed 534433252 ns 566328227 ns 0.94
tpch_q18/arrow 1102217865 ns 1145505152 ns 0.96
tpch_q18/vortex-file-compressed 1118552563 ns 1148883261 ns 0.97
tpch_q19/arrow 150883504 ns 151690965 ns 0.99
tpch_q19/vortex-file-compressed 105132200 ns 115226141 ns 0.91
tpch_q20/arrow 157451947 ns 210008194 ns 0.75
tpch_q20/vortex-file-compressed 188628272 ns 235114609 ns 0.80
tpch_q21/arrow 939040920 ns 990136748 ns 0.95
tpch_q21/vortex-file-compressed 887703188 ns 947129223 ns 0.94
tpch_q22/arrow 74014263 ns 77552378 ns 0.95
tpch_q22/vortex-file-compressed 76758971 ns 80090621 ns 0.96

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot]
github-actions bot reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clickbench

Benchmark suite Current: 2bd7aa1 Previous: 8245062 Ratio
clickbench_q00/vortex-file-compressed 4115134 ns 2018188 ns 2.04
clickbench_q01/vortex-file-compressed 30895036 ns 26288646 ns 1.18
clickbench_q02/vortex-file-compressed 4324762 ns 62652448 ns 0.06902782154657389
clickbench_q03/vortex-file-compressed 73010212 ns 68353118 ns 1.07
clickbench_q04/vortex-file-compressed 567836205 ns 596834696 ns 0.95
clickbench_q05/vortex-file-compressed 596578708 ns 599017252 ns 1.00
clickbench_q06/vortex-file-compressed 4252004 ns 2118427 ns 2.01
clickbench_q07/vortex-file-compressed 40886848 ns 40544928 ns 1.01
clickbench_q08/vortex-file-compressed 691440311 ns 986685961 ns 0.70
clickbench_q09/vortex-file-compressed 843408770 ns 855305141 ns 0.99
clickbench_q10/vortex-file-compressed 183988771 ns 193556296 ns 0.95
clickbench_q11/vortex-file-compressed 218785921 ns 230073218 ns 0.95
clickbench_q12/vortex-file-compressed 561592418 ns 577495309 ns 0.97
clickbench_q13/vortex-file-compressed 842584011 ns 905262350 ns 0.93
clickbench_q14/vortex-file-compressed 564857583 ns 663414002 ns 0.85
clickbench_q15/vortex-file-compressed 682324581 ns 701754370 ns 0.97
clickbench_q16/vortex-file-compressed 1330666943 ns 1693146648 ns 0.79
clickbench_q17/vortex-file-compressed 1234108060 ns 1552491419 ns 0.79
clickbench_q18/vortex-file-compressed 2813258731 ns 3661761709 ns 0.77
clickbench_q19/vortex-file-compressed 51950177 ns 55694749 ns 0.93
clickbench_q20/vortex-file-compressed 649427889 ns 747343295 ns 0.87
clickbench_q21/vortex-file-compressed 896256289 ns 898967736 ns 1.00
clickbench_q22/vortex-file-compressed 1954508745 ns 1998052895 ns 0.98
clickbench_q23/vortex-file-compressed 4979946085 ns 5538439568 ns 0.90
clickbench_q24/vortex-file-compressed 369814128 ns 375558719 ns 0.98
clickbench_q25/vortex-file-compressed 329766100 ns 327206954 ns 1.01
clickbench_q26/vortex-file-compressed 412742480 ns 400710846 ns 1.03
clickbench_q27/vortex-file-compressed 1230161349 ns 1286783260 ns 0.96
clickbench_q28/vortex-file-compressed 10557786640 ns 10639776379 ns 0.99
clickbench_q29/vortex-file-compressed 17751638 ns 663841864 ns 0.026740763068235782
clickbench_q30/vortex-file-compressed 508573924 ns 582193938 ns 0.87
clickbench_q31/vortex-file-compressed 523265503 ns 589714201 ns 0.89
clickbench_q32/vortex-file-compressed 2663700967 ns 2925291410 ns 0.91
clickbench_q33/vortex-file-compressed 2107204704 ns 2552387042 ns 0.83
clickbench_q34/vortex-file-compressed 2109502513 ns 2510650846 ns 0.84
clickbench_q35/vortex-file-compressed 919862317 ns 1365166955 ns 0.67
clickbench_q36/vortex-file-compressed 79232922 ns 145193296 ns 0.55
clickbench_q37/vortex-file-compressed 54383839 ns 109270341 ns 0.50
clickbench_q38/vortex-file-compressed 54944815 ns 86009140 ns 0.64
clickbench_q39/vortex-file-compressed 137972191 ns 303149988 ns 0.46
clickbench_q40/vortex-file-compressed 34265743 ns 49710479 ns 0.69
clickbench_q41/vortex-file-compressed 36814884 ns 46681979 ns 0.79
clickbench_q42/vortex-file-compressed 42609584 ns 62603835 ns 0.68

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot]
github-actions bot reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataFusion

Benchmark suite Current: 2bd7aa1 Previous: 8245062 Ratio
arrow/planning 870502.8515252402 ns (1568.130165065988) 805155.9081109226 ns (1435.5009279978112) 1.08
arrow/exec 1841984.8744204852 ns (4067.725008209236) 1772008.0602154573 ns (5180.068228581105) 1.04
vortex-pushdown-compressed/planning 548264.4602132196 ns (1834.5684410664835) 496151.3058988904 ns (1062.2128417447675) 1.11
vortex-pushdown-compressed/exec 2699748.486315789 ns (9998.116223684046) 2623251.469 ns (13395.340043750126) 1.03
vortex-pushdown-uncompressed/planning 548468.972518584 ns (1237.3926892970921) 503463.7722946773 ns (1489.5193192000152) 1.09
vortex-pushdown-uncompressed/exec 1521364.8820129754 ns (4349.8449515906395) 1494469.419876682 ns (11292.945216954686) 1.02
vortex-nopushdown-compressed/planning 906440.7187554756 ns (1586.6734623295488) 834077.9819343442 ns (1820.366536240268) 1.09
vortex-nopushdown-compressed/exec 3108888.607058825 ns (19420.97190441168) 2909320.1570588243 ns (6496.586852940964) 1.07
vortex-nopushdown-uncompressed/planning 885060.1032091795 ns (1619.0928747406579) 814619.6088212347 ns (1521.9362254769658) 1.09
vortex-nopushdown-uncompressed/exec 5188786.028 ns (74751.33772499906) 4826381.569090908 ns (6326.341238636058) 1.08

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot]
github-actions bot reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random Access

Benchmark suite Current: 2bd7aa1 Previous: 8245062 Ratio
random-access/vortex-tokio-local-disk 3405422.92375 ns (48757.056562500075) 2931660.5994444443 ns (11367.733583332738) 1.16
random-access/vortex-local-fs 3512000.2986666663 ns (37645.729174999986) 3082532.194117646 ns (15323.209705883404) 1.14
random-access/parquet-tokio-local-disk 226357055.4 ns (2636105.5333333015) 226474819.06666666 ns (4580709.799999997) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot]
github-actions bot reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vortex Compression

Benchmark suite Current: 2bd7aa1 Previous: 8245062 Ratio
compress time/taxi 1389504680.1 ns (3553172.149999976) 1342905007.4 ns (1322100.5) 1.03
compress time/taxi throughput 470810830 bytes 470810830 bytes 1
parquet_rs-zstd compress time/taxi 1713528583.7 ns (3985965.971250057) 1705948076.1 ns (2618379.1999999285) 1.00
parquet_rs-zstd compress time/taxi throughput 470810830 bytes 470810830 bytes 1
decompress time/taxi 289391684.7 ns (744690.4825000167) 299314726.45 ns (1373295.1737499833) 0.97
decompress time/taxi throughput 470810830 bytes 470810830 bytes 1
parquet_rs-zstd decompress time/taxi 314245297.4 ns (1233358.913749963) 313094511.1 ns (1314919.743750006) 1.00
parquet_rs-zstd decompress time/taxi throughput 470810830 bytes 470810830 bytes 1
vortex:parquet-zstd size/taxi 0.9314015290343367 ratio 0.9306741628650479 ratio 1.00
vortex:raw size/taxi 0.1107068501376657 ratio 0.11062039503211937 ratio 1.00
vortex size/taxi 52121984 bytes 52081280 bytes 1.00
compress time/AirlineSentiment 660053.004147113 ns (4687.669051292585) 654964.2187116022 ns (1184.6982673861203) 1.01
compress time/AirlineSentiment throughput 2066 bytes 2066 bytes 1
parquet_rs-zstd compress time/AirlineSentiment 55324.73911449459 ns (91.72810204988127) 55998.52479233375 ns (122.60193487264769) 0.99
parquet_rs-zstd compress time/AirlineSentiment throughput 2066 bytes 2066 bytes 1
decompress time/AirlineSentiment 98268.19063925752 ns (606.4505752472032) 98984.22611520569 ns (420.8310938006325) 0.99
decompress time/AirlineSentiment throughput 2066 bytes 2066 bytes 1
parquet_rs-zstd decompress time/AirlineSentiment 32701.5650023393 ns (68.34734122347982) 32652.18940375107 ns (107.82156864443277) 1.00
parquet_rs-zstd decompress time/AirlineSentiment throughput 2066 bytes 2066 bytes 1
vortex:parquet-zstd size/AirlineSentiment 8.781799379524301 ratio 8.781799379524301 ratio 1
vortex:raw size/AirlineSentiment 4.110358180058083 ratio 4.110358180058083 ratio 1
vortex size/AirlineSentiment 8492 bytes 8492 bytes 1
compress time/Arade 2727388134.3 ns (5619251.024999857) 2657697847.3 ns (9584535.20625019) 1.03
compress time/Arade throughput 787035849 bytes 787035849 bytes 1
parquet_rs-zstd compress time/Arade 2925532393.1 ns (6535375.84375) 2899176045.9 ns (5445956.633749962) 1.01
parquet_rs-zstd compress time/Arade throughput 787035849 bytes 787035849 bytes 1
decompress time/Arade 408069739.2 ns (1499940.6849999726) 411267307.1 ns (1487039.6037499905) 0.99
decompress time/Arade throughput 787035849 bytes 787035849 bytes 1
parquet_rs-zstd decompress time/Arade 707029444.5 ns (3263034.4500000477) 698864283.2 ns (3321377.587499976) 1.01
parquet_rs-zstd decompress time/Arade throughput 787035849 bytes 787035849 bytes 1
vortex:parquet-zstd size/Arade 0.46660109392238946 ratio 0.4665336136915136 ratio 1.00
vortex:raw size/Arade 0.1810550004565294 ratio 0.18102881613465108 ratio 1.00
vortex size/Arade 142496776 bytes 142476168 bytes 1.00
compress time/Bimbo 11089884932.6 ns (25445407.517499924) 10553257821.3 ns (22865636.619999886) 1.05
compress time/Bimbo throughput 7121348333 bytes 7121348333 bytes 1
parquet_rs-zstd compress time/Bimbo 20432172830.8 ns (18744511.07249832) 20274598600.9 ns (24544985.87999916) 1.01
parquet_rs-zstd compress time/Bimbo throughput 7121348333 bytes 7121348333 bytes 1
decompress time/Bimbo 3516056999.1 ns (4778354.012500048) 3525008990.8 ns (12345029.153749943) 1.00
decompress time/Bimbo throughput 7121348333 bytes 7121348333 bytes 1
parquet_rs-zstd decompress time/Bimbo 3694308313.3 ns (8341588.556250095) 4638747278.6 ns (22310326.643749714) 0.80
parquet_rs-zstd decompress time/Bimbo throughput 7121348333 bytes 7121348333 bytes 1
vortex:parquet-zstd size/Bimbo 1.369451262739341 ratio 1.3680744788554824 ratio 1.00
vortex:raw size/Bimbo 0.07464230243264523 ratio 0.0745672514767015 ratio 1.00
vortex size/Bimbo 531553836 bytes 531019372 bytes 1.00
compress time/CMSprovider 12893554104.1 ns (13847595.433750153) 12858991956.2 ns (18254217.77374935) 1.00
compress time/CMSprovider throughput 5149200493 bytes 5149200493 bytes 1
parquet_rs-zstd compress time/CMSprovider 18449092259.3 ns (24036621.682498932) 18450499355.5 ns (20863002.700000763) 1.00
parquet_rs-zstd compress time/CMSprovider throughput 5149200493 bytes 5149200493 bytes 1
decompress time/CMSprovider 2803079247.5 ns (382060386.79999995) 2532771015.5 ns (387026989.3000001) 1.11
decompress time/CMSprovider throughput 5149200493 bytes 5149200493 bytes 1
parquet_rs-zstd decompress time/CMSprovider 5610275808.1 ns (9729955.002500057) 5487317953.5 ns (18004463.6387496) 1.02
parquet_rs-zstd decompress time/CMSprovider throughput 5149200493 bytes 5149200493 bytes 1
vortex:parquet-zstd size/CMSprovider 1.2321540765093029 ratio 1.2320259957389077 ratio 1.00
vortex:raw size/CMSprovider 0.1841380597413067 ratio 0.18411276649429156 ratio 1.00
vortex size/CMSprovider 948163788 bytes 948033548 bytes 1.00
compress time/Euro2016 2135938645.8 ns (4091837.9987499714) 2148450120.4 ns (3524386.068750143) 0.99
compress time/Euro2016 throughput 393256178 bytes 393256178 bytes 1
parquet_rs-zstd compress time/Euro2016 1532272523.8 ns (3818980.636250019) 1532948738.8 ns (2336953.2999999523) 1.00
parquet_rs-zstd compress time/Euro2016 throughput 393256178 bytes 393256178 bytes 1
decompress time/Euro2016 238994217.9 ns (812820.950000003) 241905414.4 ns (1522869.981250003) 0.99
decompress time/Euro2016 throughput 393256178 bytes 393256178 bytes 1
parquet_rs-zstd decompress time/Euro2016 489857083.7 ns (2104261.055000007) 495430191.8 ns (1713113.4975000024) 0.99
parquet_rs-zstd decompress time/Euro2016 throughput 393256178 bytes 393256178 bytes 1
vortex:parquet-zstd size/Euro2016 1.4149621161240165 ratio 1.4149346621505106 ratio 1.00
vortex:raw size/Euro2016 0.4277738161814714 ratio 0.42776551624829146 ratio 1.00
vortex size/Euro2016 168224696 bytes 168221432 bytes 1.00
compress time/Food 1051895183.2 ns (3559915.870000005) 1094495959.2 ns (13140431.149999976) 0.96
compress time/Food throughput 332721678 bytes 332721678 bytes 1
parquet_rs-zstd compress time/Food 1034772367.3 ns (3113649.506250024) 1033047658.5 ns (1665305.844999969) 1.00
parquet_rs-zstd compress time/Food throughput 332721678 bytes 332721678 bytes 1
decompress time/Food 107384499.20809522 ns (740496.6360833272) 107287312.71107143 ns (560503.5737053528) 1.00
decompress time/Food throughput 332721678 bytes 332721678 bytes 1
parquet_rs-zstd decompress time/Food 224819677.45 ns (851925.2293750048) 226893034.55 ns (514435.424999997) 0.99
parquet_rs-zstd decompress time/Food throughput 332721678 bytes 332721678 bytes 1
vortex:parquet-zstd size/Food 1.209759985457361 ratio 1.2095250421246053 ratio 1.00
vortex:raw size/Food 0.13173058113754765 ratio 0.13170499819371553 ratio 1.00
vortex size/Food 43829620 bytes 43821108 bytes 1.00
compress time/HashTags 2595271515.7 ns (5037099.300000191) 2597229114.5 ns (3365577.8537499905) 1.00
compress time/HashTags throughput 804503131 bytes 804503131 bytes 1
parquet_rs-zstd compress time/HashTags 2426844543.3 ns (3623753.0500001907) 2426796114.7 ns (3814280.4562499523) 1.00
parquet_rs-zstd compress time/HashTags throughput 804503131 bytes 804503131 bytes 1
decompress time/HashTags 445691541 ns (1448643.1949999928) 442904155.3 ns (1551438.7725000083) 1.01
decompress time/HashTags throughput 804503131 bytes 804503131 bytes 1
parquet_rs-zstd decompress time/HashTags 783008842.2 ns (3316143.634999931) 786127118.5 ns (3818417.086250007) 1.00
parquet_rs-zstd decompress time/HashTags throughput 804503131 bytes 804503131 bytes 1
vortex:parquet-zstd size/HashTags 1.6274550332354978 ratio 1.6273981827768818 ratio 1.00
vortex:raw size/HashTags 0.27100307705328247 ratio 0.2709936103405917 ratio 1.00
vortex size/HashTags 218022824 bytes 218015208 bytes 1.00
compress time/TPC-H l_comment chunked without fsst 3142736625.7 ns (16890841.24000001) 3147616442.3 ns (7961013.468750238) 1.00
compress time/TPC-H l_comment chunked without fsst throughput 249225147 bytes 249225147 bytes 1
parquet_rs-zstd compress time/TPC-H l_comment chunked without fsst 912854095.1 ns (7096532.038749993) 915845648.5 ns (3574441.699999988) 1.00
parquet_rs-zstd compress time/TPC-H l_comment chunked without fsst throughput 249225147 bytes 249225147 bytes 1
decompress time/TPC-H l_comment chunked without fsst 84607174.8 ns (8213194.043749988) 82903018.2 ns (9675299.997499995) 1.02
decompress time/TPC-H l_comment chunked without fsst throughput 249225147 bytes 249225147 bytes 1
parquet_rs-zstd decompress time/TPC-H l_comment chunked without fsst 249454165.9 ns (618818.275000006) 250794311.85 ns (733697.3418750018) 0.99
parquet_rs-zstd decompress time/TPC-H l_comment chunked without fsst throughput 249225147 bytes 249225147 bytes 1
vortex:parquet-zstd size/TPC-H l_comment chunked without fsst 4.607512862709998 ratio 4.6078018520340995 ratio 1.00
vortex:raw size/TPC-H l_comment chunked without fsst 1.052640743351633 ratio 1.05260581910701 ratio 1.00
vortex size/TPC-H l_comment chunked without fsst 262344544 bytes 262335840 bytes 1.00
compress time/TPC-H l_comment chunked 978798582.7 ns (3693201.5287500024) 987314965.6 ns (2037252.9337499738) 0.99
compress time/TPC-H l_comment chunked throughput 249225147 bytes 249225147 bytes 1
parquet_rs-zstd compress time/TPC-H l_comment chunked 911066501.7 ns (2740730.38500005) 913030392.3 ns (2159445.9037500024) 1.00
parquet_rs-zstd compress time/TPC-H l_comment chunked throughput 249225147 bytes 249225147 bytes 1
decompress time/TPC-H l_comment chunked 89667554.71111111 ns (369979.6404861137) 89035234.3127381 ns (367726.82541219145) 1.01
decompress time/TPC-H l_comment chunked throughput 249225147 bytes 249225147 bytes 1
parquet_rs-zstd decompress time/TPC-H l_comment chunked 249342774.85 ns (935243.6931249946) 249886875.55 ns (404686.97499999404) 1.00
parquet_rs-zstd decompress time/TPC-H l_comment chunked throughput 249225147 bytes 249225147 bytes 1
vortex:parquet-zstd size/TPC-H l_comment chunked 1.160183748659451 ratio 1.1603444745697349 ratio 1.00
vortex:raw size/TPC-H l_comment chunked 0.26505768296326854 ratio 0.2650689819835877 ratio 1.00
vortex size/TPC-H l_comment chunked 66059040 bytes 66061856 bytes 1.00
compress time/TPC-H l_comment canonical 979658937.3 ns (923034.1824999452) 984245347.65 ns (1014179.4568750262) 1.00
compress time/TPC-H l_comment canonical throughput 249224435 bytes 249224435 bytes 1
parquet_rs-zstd compress time/TPC-H l_comment canonical 909085217.2 ns (1537276.9500000477) 908831844.35 ns (2123259.682500005) 1.00
parquet_rs-zstd compress time/TPC-H l_comment canonical throughput 249224435 bytes 249224435 bytes 1
decompress time/TPC-H l_comment canonical 89096416.27092591 ns (327956.7588888779) 89317969.21216932 ns (360006.6897242069) 1.00
decompress time/TPC-H l_comment canonical throughput 249224435 bytes 249224435 bytes 1
parquet_rs-zstd decompress time/TPC-H l_comment canonical 249053390.17619053 ns (480629.4235416651) 249722414.69027776 ns (469534.45619791746) 1.00
parquet_rs-zstd decompress time/TPC-H l_comment canonical throughput 249224435 bytes 249224435 bytes 1
vortex:parquet-zstd size/TPC-H l_comment canonical 1.1602269883784349 ratio 1.16037044040231 ratio 1.00
vortex:raw size/TPC-H l_comment canonical 0.26505844019668456 ratio 0.2650697392492835 ratio 1.00
vortex size/TPC-H l_comment canonical 66059040 bytes 66061856 bytes 1.00

This comment was automatically generated by workflow using github-action-benchmark.

a10y
a10y reviewed Dec 12, 2024
View reviewed changes
vortex-array/src/stats/statsset.rs
@@ -213,6 +214,11 @@ impl StatsSet {
}
}

fn merge_sum(&mut self, _other: &Self) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to implement this so chunkedarray inherits the sum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@a10y a10y a10y left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatesn @a10y