Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: collect coverage from Rust tests #1470

Merged
merged 8 commits into from
Dec 17, 2024
Merged

chore: collect coverage from Rust tests #1470

merged 8 commits into from
Dec 17, 2024

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 25, 2024

No description provided.

@lwwmanning lwwmanning added the do not merge Pull requests that are not intended to merge label Nov 27, 2024
@gatesn gatesn marked this pull request as ready for review December 17, 2024 10:55
@gatesn gatesn enabled auto-merge (squash) December 17, 2024 10:55
@gatesn
Copy link
Contributor Author

gatesn commented Dec 17, 2024

@lwwmanning is it worth merging this?

@lwwmanning
Copy link
Member

@lwwmanning is it worth merging this?

Yeah, I'm all for it. Can you link/pin to coverall in the slack channel? Or perhaps redirect to it from coverage.vortex.dev

@lwwmanning lwwmanning removed the do not merge Pull requests that are not intended to merge label Dec 17, 2024
@lwwmanning lwwmanning changed the title Attempt to run coverage chore: collect coverage from Rust tests Dec 17, 2024
@lwwmanning lwwmanning disabled auto-merge December 17, 2024 16:50
@lwwmanning lwwmanning enabled auto-merge (squash) December 17, 2024 16:50
@lwwmanning lwwmanning merged commit e69bde8 into develop Dec 17, 2024
20 checks passed
@lwwmanning lwwmanning deleted the ngates/coverage branch December 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwwmanning lwwmanning lwwmanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatesn @lwwmanning