Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new "scan throughput" objective in sampling compressor #1068

Closed
wants to merge 3 commits into from

Conversation

lwwmanning
Copy link
Member

@lwwmanning lwwmanning commented Oct 17, 2024

new objective function that biases more strongly towards the fastest codecs, while still taking compressed size into account

@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 7, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vortex bytes_at

Benchmark suite Current: caafb0e Previous: 258877b Ratio
bytes_at/array_data 1055.8254941830005 ns (1.0012082793430181) 1093.2360461171459 ns (1.2600787688761557) 0.97
bytes_at/array_view 897.7067509625406 ns (0.9712963339388239) 879.6228216442003 ns (0.9326148590901084) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataFusion

Benchmark suite Current: caafb0e Previous: 258877b Ratio
arrow/planning 806746.3865326797 ns (1272.7847213761415) 809766.975310695 ns (1267.5596869026776) 1.00
arrow/exec 1772782.8676691127 ns (5942.947165077785) 1782764.6372715642 ns (6408.82638496405) 0.99
vortex-pushdown-compressed/planning 501121.7329601518 ns (1108.2148198893701) 505407.07995783025 ns (1256.0154029907135) 0.99
vortex-pushdown-compressed/exec 2625487.3339999993 ns (10710.471731249942) 2627948.9484210517 ns (7006.934914473677) 1.00
vortex-pushdown-uncompressed/planning 502476.7667716834 ns (1280.4225700958923) 506006.6567445785 ns (1528.9592264432576) 0.99
vortex-pushdown-uncompressed/exec 1490345.7754847063 ns (6594.273453914677) 1496003.3332646918 ns (8676.180741103017) 1.00
vortex-nopushdown-compressed/planning 838876.4798145187 ns (1482.2678449653322) 842467.4049236067 ns (1650.7722999678808) 1.00
vortex-nopushdown-compressed/exec 3659028.0342857153 ns (16595.49203571328) 3521818.095714286 ns (9738.302919642767) 1.04
vortex-nopushdown-uncompressed/planning 822182.4989501089 ns (1561.2568258638494) 826218.2421167763 ns (2003.6868527127663) 1.00
vortex-nopushdown-uncompressed/exec 5009048.006000001 ns (13448.186850000173) 4942082.188181817 ns (9344.970965909772) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random Access

Benchmark suite Current: caafb0e Previous: 258877b Ratio
random-access/vortex-tokio-local-disk 2488794.2115 ns (25084.979981249664) 2241051.7460869565 ns (15304.25591847836) 1.11
random-access/vortex-local-fs 3072617.5488235294 ns (19734.015080883168) 2800056.870555556 ns (19826.51138888998) 1.10
random-access/parquet-tokio-local-disk 215532863.83333334 ns (4802359.133333325) 227940412 ns (4725891.874166697) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPC-H

Benchmark suite Current: caafb0e Previous: 258877b Ratio
tpch_q1/arrow 543352001 ns 538810803 ns 1.01
tpch_q1/parquet 773903237 ns 771460999 ns 1.00
tpch_q1/vortex-file-compressed 501955635 ns 502454294 ns 1.00
tpch_q2/arrow 145578080 ns 145033377 ns 1.00
tpch_q2/parquet 174001932 ns 178965192 ns 0.97
tpch_q2/vortex-file-compressed 174442205 ns 174470089 ns 1.00
tpch_q3/arrow 168362417 ns 170184357 ns 0.99
tpch_q3/parquet 378492001 ns 376163026 ns 1.01
tpch_q3/vortex-file-compressed 240717557 ns 244691623 ns 0.98
tpch_q4/arrow 176600775 ns 177417793 ns 1.00
tpch_q4/parquet 217936409 ns 215536036 ns 1.01
tpch_q4/vortex-file-compressed 151462965 ns 165427731 ns 0.92
tpch_q5/arrow 325478659 ns 326970969 ns 1.00
tpch_q5/parquet 520393177 ns 508065430 ns 1.02
tpch_q5/vortex-file-compressed 355502147 ns 339295935 ns 1.05
tpch_q6/arrow 25837351 ns 26678721 ns 0.97
tpch_q6/parquet 151138872 ns 153974598 ns 0.98
tpch_q6/vortex-file-compressed 13644812 ns 14004159 ns 0.97
tpch_q7/arrow 617595741 ns 624087677 ns 0.99
tpch_q7/parquet 761945871 ns 771318958 ns 0.99
tpch_q7/vortex-file-compressed 659466056 ns 660229702 ns 1.00
tpch_q8/arrow 265879170 ns 265846977 ns 1.00
tpch_q8/parquet 541531082 ns 546911572 ns 0.99
tpch_q8/vortex-file-compressed 276356051 ns 285016523 ns 0.97
tpch_q9/arrow 468560204 ns 473851190 ns 0.99
tpch_q9/parquet 782119561 ns 781605828 ns 1.00
tpch_q9/vortex-file-compressed 503141163 ns 486014943 ns 1.04
tpch_q10/arrow 261758931 ns 269518229 ns 0.97
tpch_q10/parquet 517674776 ns 516176016 ns 1.00
tpch_q10/vortex-file-compressed 290424834 ns 291613646 ns 1.00
tpch_q11/arrow 142169375 ns 141692821 ns 1.00
tpch_q11/parquet 144210636 ns 149463387 ns 0.96
tpch_q11/vortex-file-compressed 193458781 ns 201098566 ns 0.96
tpch_q12/arrow 186086197 ns 183884250 ns 1.01
tpch_q12/parquet 327466419 ns 330705780 ns 0.99
tpch_q12/vortex-file-compressed 178899898 ns 181663076 ns 0.98
tpch_q13/arrow 171773788 ns 169776253 ns 1.01
tpch_q13/parquet 308748508 ns 315769147 ns 0.98
tpch_q13/vortex-file-compressed 174116537 ns 182820545 ns 0.95
tpch_q14/arrow 38124583 ns 39639847 ns 0.96
tpch_q14/parquet 232762680 ns 233600581 ns 1.00
tpch_q14/vortex-file-compressed 76630136 ns 75834389 ns 1.01
tpch_q15/arrow 68355534 ns 69276003 ns 0.99
tpch_q15/parquet 327044816 ns 325334818 ns 1.01
tpch_q15/vortex-file-compressed 143445472 ns 143332572 ns 1.00
tpch_q16/arrow 103514599 ns 105605757 ns 0.98
tpch_q16/parquet 118994159 ns 122874516 ns 0.97
tpch_q16/vortex-file-compressed 117075294 ns 117220367 ns 1.00
tpch_q17/arrow 600675042 ns 611886005 ns 0.98
tpch_q17/parquet 689257376 ns 680963815 ns 1.01
tpch_q17/vortex-file-compressed 619227615 ns 626445002 ns 0.99
tpch_q18/arrow 1143245638 ns 1149548820 ns 0.99
tpch_q18/parquet 1336554746 ns 1365268419 ns 0.98
tpch_q18/vortex-file-compressed 1116597674 ns 1136459135 ns 0.98
tpch_q19/arrow 151084061 ns 153221100 ns 0.99
tpch_q19/parquet 425693950 ns 425303795 ns 1.00
tpch_q19/vortex-file-compressed 138241489 ns 143615473 ns 0.96
tpch_q20/arrow 215135263 ns 218455968 ns 0.98
tpch_q20/parquet 352835016 ns 349223929 ns 1.01
tpch_q20/vortex-file-compressed 274526810 ns 282711721 ns 0.97
tpch_q21/arrow 989101815 ns 994771810 ns 0.99
tpch_q21/parquet 1099999437 ns 1123983935 ns 0.98
tpch_q21/vortex-file-compressed 1041880506 ns 1056357185 ns 0.99
tpch_q22/arrow 78590231 ns 79037775 ns 0.99
tpch_q22/parquet 109608640 ns 111389754 ns 0.98
tpch_q22/vortex-file-compressed 80468720 ns 84448861 ns 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vortex Compression

Benchmark suite Current: caafb0e Previous: 918ec30 Ratio
compress time/taxi 1349446721.2 ns (2004974.6075000763) 1331003904.1 ns (2426039.3000000715) 1.01
compress time/taxi throughput 470808924 bytes 470808924 bytes 1
parquet_rs-zstd compress time/taxi 1687700606.2 ns (3725018.091249943) 1734307076.2 ns (13304806.212499976) 0.97
parquet_rs-zstd compress time/taxi throughput 470808924 bytes 470808924 bytes 1
decompress time/taxi 359198924.5 ns (1156253.699999988) 370928939.1 ns (2269350.449999988) 0.97
decompress time/taxi throughput 470808924 bytes 470808924 bytes 1
parquet_rs-zstd decompress time/taxi 306660635 ns (729784.1200000048) 311213485.5 ns (1045868.1999999881) 0.99
parquet_rs-zstd decompress time/taxi throughput 470808924 bytes 470808924 bytes 1
vortex:parquet-zstd size/taxi 1.030319611170746 ratio 0.9844120555081315 ratio 1.05
vortex:raw size/taxi 0.12246479847947826 ratio 0.11700872517870965 ratio 1.05
vortex size/taxi 57657520 bytes 55088752 bytes 1.05
compress time/AirlineSentiment 971813.3431758697 ns (2416.994133105385) 934620.7668106692 ns (1330.82158881519) 1.04
compress time/AirlineSentiment throughput 2020 bytes 2020 bytes 1
parquet_rs-zstd compress time/AirlineSentiment 55456.6080965681 ns (94.48624890999781) 55066.42344992338 ns (69.39326144938968) 1.01
parquet_rs-zstd compress time/AirlineSentiment throughput 2020 bytes 2020 bytes 1
decompress time/AirlineSentiment 106779.44004703464 ns (616.5582083026966) 98894.5795511768 ns (465.2727456832363) 1.08
decompress time/AirlineSentiment throughput 2020 bytes 2020 bytes 1
parquet_rs-zstd decompress time/AirlineSentiment 33077.306061063406 ns (38.300202645503305) 31873.845770410757 ns (29.433234595449903) 1.04
parquet_rs-zstd decompress time/AirlineSentiment throughput 2020 bytes 2020 bytes 1
vortex:parquet-zstd size/AirlineSentiment 11.7435367114788 ratio 9.427094105480869 ratio 1.25
vortex:raw size/AirlineSentiment 5.6217821782178214 ratio 4.512871287128712 ratio 1.25
vortex size/AirlineSentiment 11356 bytes 9116 bytes 1.25
compress time/Arade 2940083049.3 ns (3524040.75) 3079004738.1 ns (15556515.38625002) 0.95
compress time/Arade throughput 787023760 bytes 787023760 bytes 1
parquet_rs-zstd compress time/Arade 2865726255.4 ns (8868343.831249952) 2869548601.1 ns (4954216) 1.00
parquet_rs-zstd compress time/Arade throughput 787023760 bytes 787023760 bytes 1
decompress time/Arade 609958415.7 ns (1647212.8499999642) 611857421.3 ns (873459.6500000358) 1.00
decompress time/Arade throughput 787023760 bytes 787023760 bytes 1
parquet_rs-zstd decompress time/Arade 668936426.2 ns (1939307.1925000548) 670102738 ns (2554667.519999981) 1.00
parquet_rs-zstd decompress time/Arade throughput 787023760 bytes 787023760 bytes 1
vortex:parquet-zstd size/Arade 0.49388610705755653 ratio 0.48881733580229075 ratio 1.01
vortex:raw size/Arade 0.1916453348244531 ratio 0.18967830907671707 ratio 1.01
vortex size/Arade 150829432 bytes 149281336 bytes 1.01
compress time/Bimbo 10621196603.5 ns (12885560) 9477494162.5 ns (16204721.622499466) 1.12
compress time/Bimbo throughput 7121333608 bytes 7121333608 bytes 1
parquet_rs-zstd compress time/Bimbo 19311388096.1 ns (35120561.89999962) 19187025940.6 ns (46029357.449998856) 1.01
parquet_rs-zstd compress time/Bimbo throughput 7121333608 bytes 7121333608 bytes 1
decompress time/Bimbo 3798247003.2 ns (6726703.712500095) 3874744580 ns (4205306.200000286) 0.98
decompress time/Bimbo throughput 7121333608 bytes 7121333608 bytes 1
parquet_rs-zstd decompress time/Bimbo 2659043156.6 ns (5099556.690000057) 2679585246.9 ns (9276572.180000067) 0.99
parquet_rs-zstd decompress time/Bimbo throughput 7121333608 bytes 7121333608 bytes 1
vortex:parquet-zstd size/Bimbo 1.8277250112243697 ratio 1.2757810910533085 ratio 1.43
vortex:raw size/Bimbo 0.0996208400071348 ratio 0.06953692879149835 ratio 1.43
vortex size/Bimbo 709433236 bytes 495195668 bytes 1.43
compress time/CMSprovider 16062213727.9 ns (30151925.89999962) 16245234622.8 ns (19952025.898750305) 0.99
compress time/CMSprovider throughput 5149123964 bytes 5149123964 bytes 1
parquet_rs-zstd compress time/CMSprovider 18564594430 ns (27999349.36499977) 18731723178.5 ns (15113960.300001144) 0.99
parquet_rs-zstd compress time/CMSprovider throughput 5149123964 bytes 5149123964 bytes 1
decompress time/CMSprovider 4069241260.3 ns (330223427.64999986) 4336367945.9 ns (386830687.28) 0.94
decompress time/CMSprovider throughput 5149123964 bytes 5149123964 bytes 1
parquet_rs-zstd decompress time/CMSprovider 5110177937.6 ns (11972232.868750572) 5285978800.4 ns (16654815.887500286) 0.97
parquet_rs-zstd decompress time/CMSprovider throughput 5149123964 bytes 5149123964 bytes 1
vortex:parquet-zstd size/CMSprovider 1.33255558399398 ratio 1.2244510058058404 ratio 1.09
vortex:raw size/CMSprovider 0.19914469862625353 ratio 0.18298797748657192 ratio 1.09
vortex size/CMSprovider 1025420740 bytes 942227780 bytes 1.09
compress time/Euro2016 3153796765.6 ns (3620978.5999999046) 2880129342.4 ns (14255536.444999933) 1.10
compress time/Euro2016 throughput 393253221 bytes 393253221 bytes 1
parquet_rs-zstd compress time/Euro2016 1527715110.8 ns (3144393.2999999523) 1529540225.1 ns (2347171.377499938) 1.00
parquet_rs-zstd compress time/Euro2016 throughput 393253221 bytes 393253221 bytes 1
decompress time/Euro2016 296091638.4 ns (1136861.4100000262) 308857769.5 ns (1124135.3250000179) 0.96
decompress time/Euro2016 throughput 393253221 bytes 393253221 bytes 1
parquet_rs-zstd decompress time/Euro2016 489387381.6 ns (1612226.7350000143) 484257239.7 ns (1329712.838749975) 1.01
parquet_rs-zstd decompress time/Euro2016 throughput 393253221 bytes 393253221 bytes 1
vortex:parquet-zstd size/Euro2016 1.5036759978943206 ratio 1.4428719063371358 ratio 1.04
vortex:raw size/Euro2016 0.4545973699729722 ratio 0.4362148326815612 ratio 1.04
vortex size/Euro2016 178771880 bytes 171542888 bytes 1.04
compress time/Food 1283383911.1 ns (2396351.8600000143) 1456964499.1 ns (8975661.25) 0.88
compress time/Food throughput 332718229 bytes 332718229 bytes 1
parquet_rs-zstd compress time/Food 1028157926.6 ns (1912472.4337500334) 1022634260.4 ns (807142.2212499976) 1.01
parquet_rs-zstd compress time/Food throughput 332718229 bytes 332718229 bytes 1
decompress time/Food 121687262.66666667 ns (120801.20666667819) 163547470.65 ns (490570.9806249887) 0.74
decompress time/Food throughput 332718229 bytes 332718229 bytes 1
parquet_rs-zstd decompress time/Food 224793955.95 ns (1136941.3568750024) 222008368.35 ns (567274.7018750012) 1.01
parquet_rs-zstd decompress time/Food throughput 332718229 bytes 332718229 bytes 1
vortex:parquet-zstd size/Food 1.4227146978942569 ratio 1.2761383221143199 ratio 1.11
vortex:raw size/Food 0.15492079335394635 ratio 0.13895994859963023 ratio 1.11
vortex size/Food 51544972 bytes 46234508 bytes 1.11
compress time/HashTags 2839364524.8 ns (3312198.4187500477) 2917823510.6 ns (3683391.0574998856) 0.97
compress time/HashTags throughput 804495592 bytes 804495592 bytes 1
parquet_rs-zstd compress time/HashTags 2428194404.9 ns (4348134.366250038) 2428430517.2 ns (3480261.480000019) 1.00
parquet_rs-zstd compress time/HashTags throughput 804495592 bytes 804495592 bytes 1
decompress time/HashTags 446574246.1 ns (961825.5262500048) 486471703.8 ns (1294464.6912500262) 0.92
decompress time/HashTags throughput 804495592 bytes 804495592 bytes 1
parquet_rs-zstd decompress time/HashTags 773840047.8 ns (2347027.6799999475) 788387392.7 ns (4686449.791249931) 0.98
parquet_rs-zstd decompress time/HashTags throughput 804495592 bytes 804495592 bytes 1
vortex:parquet-zstd size/HashTags 1.6761976132093355 ratio 1.6702555459466137 ratio 1.00
vortex:raw size/HashTags 0.27912228511004694 ratio 0.278132805480928 ratio 1.00
vortex size/HashTags 224552648 bytes 223756616 bytes 1.00
compress time/TPC-H l_comment chunked without fsst 4538114763.7 ns (8963303.328749657) 4499603184.1 ns (11455314.837500572) 1.01
compress time/TPC-H l_comment chunked without fsst throughput 249197098 bytes 249197098 bytes 1
parquet_rs-zstd compress time/TPC-H l_comment chunked without fsst 901402897.3 ns (1952067.9724999666) 900851402.2 ns (1977046.9000000358) 1.00
parquet_rs-zstd compress time/TPC-H l_comment chunked without fsst throughput 249197098 bytes 249197098 bytes 1
decompress time/TPC-H l_comment chunked without fsst 156143207 ns (856842.181250006) 132732701.1 ns (829625.7662499994) 1.18
decompress time/TPC-H l_comment chunked without fsst throughput 249197098 bytes 249197098 bytes 1
parquet_rs-zstd decompress time/TPC-H l_comment chunked without fsst 248177213.9 ns (883196.599999994) 247338690.1 ns (543691.1831249893) 1.00
parquet_rs-zstd decompress time/TPC-H l_comment chunked without fsst throughput 249197098 bytes 249197098 bytes 1
vortex:parquet-zstd size/TPC-H l_comment chunked without fsst 4.609845836503251 ratio 4.60975814361312 ratio 1.00
vortex:raw size/TPC-H l_comment chunked without fsst 1.0531798086990563 ratio 1.0531710766551543 ratio 1.00
vortex size/TPC-H l_comment chunked without fsst 262449352 bytes 262447176 bytes 1.00
compress time/TPC-H l_comment chunked 1345418524.3 ns (4182275.350000024) 1359673904.1 ns (3462605.102499962) 0.99
compress time/TPC-H l_comment chunked throughput 249197098 bytes 249197098 bytes 1
parquet_rs-zstd compress time/TPC-H l_comment chunked 902806484.9 ns (1952498.9200000167) 901449609.9 ns (1775456.7825000286) 1.00
parquet_rs-zstd compress time/TPC-H l_comment chunked throughput 249197098 bytes 249197098 bytes 1
decompress time/TPC-H l_comment chunked 139415562.49999997 ns (693106.1987500042) 102108080.68547618 ns (506288.5558125004) 1.37
decompress time/TPC-H l_comment chunked throughput 249197098 bytes 249197098 bytes 1
parquet_rs-zstd decompress time/TPC-H l_comment chunked 248275197.05 ns (911089.7287500054) 248196851.1 ns (535927.8118750006) 1.00
parquet_rs-zstd decompress time/TPC-H l_comment chunked throughput 249197098 bytes 249197098 bytes 1
vortex:parquet-zstd size/TPC-H l_comment chunked 1.5045721018818317 ratio 1.3526467620864961 ratio 1.11
vortex:raw size/TPC-H l_comment chunked 0.3437392517307726 ratio 0.30903322959242485 ratio 1.11
vortex size/TPC-H l_comment chunked 85658824 bytes 77010184 bytes 1.11
compress time/TPC-H l_comment canonical 1342531418.4 ns (1141678.1900000572) 1364782773.5 ns (1977378.0393749475) 0.98
compress time/TPC-H l_comment canonical throughput 249197114 bytes 249197114 bytes 1
parquet_rs-zstd compress time/TPC-H l_comment canonical 905644991.65 ns (1645016.4293749928) 904803452 ns (1699333.75) 1.00
parquet_rs-zstd compress time/TPC-H l_comment canonical throughput 249197114 bytes 249197114 bytes 1
decompress time/TPC-H l_comment canonical 138243101.64746028 ns (804794.5613888949) 102423660.6775 ns (274490.91363541037) 1.35
decompress time/TPC-H l_comment canonical throughput 249197114 bytes 249197114 bytes 1
parquet_rs-zstd decompress time/TPC-H l_comment canonical 247652111.0586111 ns (680387.8272048384) 248689870.99896827 ns (472601.06834225357) 1.00
parquet_rs-zstd decompress time/TPC-H l_comment canonical throughput 249197114 bytes 249197114 bytes 1
vortex:parquet-zstd size/TPC-H l_comment canonical 1.5045864785070489 ratio 1.3526908832242368 ratio 1.11
vortex:raw size/TPC-H l_comment canonical 0.34373922966058107 ratio 0.3090332097505752 ratio 1.11
vortex size/TPC-H l_comment canonical 85658824 bytes 77010184 bytes 1.11

This comment was automatically generated by workflow using github-action-benchmark.

@lwwmanning lwwmanning changed the title [WIP] ScanPerf objective in sampling compressor feat: ScanPerf objective in sampling compressor Nov 7, 2024
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 7, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 8, 2024
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 8, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 8, 2024
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 8, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 8, 2024
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 8, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 8, 2024
lwwmanning added a commit that referenced this pull request Nov 8, 2024
No real changes, just moving code around to make the diff on #1068
smaller.

The `SamplingCompressor` from `lib.rs` into its own file. Additionally,
the previously standalone `objective_function` is now
`Objective::evaluate`
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 8, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 9, 2024
@lwwmanning lwwmanning changed the title feat: ScanPerf objective in sampling compressor feat: new "scan throughput" objective in sampling compressor Nov 18, 2024
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 20, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 20, 2024
@lwwmanning lwwmanning force-pushed the wm/scanperf branch 2 times, most recently from f231070 to aa9950f Compare November 21, 2024 22:03
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 21, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 21, 2024
@lwwmanning
Copy link
Member Author

Current state: makes TPC-H ~5% faster on a few queries, makes Q12 ~15% faster, rest unchanged.

Maybe-unrelated-looking panic in the compression benchmarks (looks like an IO thing), need to investigate. Also need to check file size and decompression throughput

@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Nov 22, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Nov 22, 2024
@lwwmanning
Copy link
Member Author

decompression throughput is a mixed bag (sometimes a bit better, sometimes worse), TPC-H benefits seem marginal (0-5%), but with big increase in size

@lwwmanning lwwmanning closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants