-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped aws sdk version for FIPS compliance #1043
base: master
Are you sure you want to change the base?
Bumped aws sdk version for FIPS compliance #1043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this built. Until version 1.12.399 of https://github.com/Netflix/awsobjectmapper exists, I don't think this is gonna work. That repo is totally open to contributions though, so please make a PR there.
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
@dbyron-sf made a pull request for https://github.com/Netflix/awsobjectmapper do you know who I may reach to give a look to the request? |
Thanks. They're usually pretty prompt. |
@Mergifyio update |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
@cs-simental could you rebase please? Also would be great if you can link to some docs showing 1.12.399 as the minimum version for govcloud fips compliance. |
623d8b7
to
9bb6e97
Compare
9bb6e97
to
65eae85
Compare
@dbyron-sf rebased. Link to FIPS documentation in aws-java-sdk: |
Thanks @cs-simental . Can you also let us know where you've tested this please. |
Hello 👋 updating the sdk also helps with Configuring lambda SnapStart as it was introduced in 1.12.351 see issue: spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker#128 |
Thanks for highlighting this - we're working on moving the Lambda plugin into the main codebase and snapstart was on my list of things to add once that effort was done. |
Version 1.12.399 is the lowest version that enables FIPS endpoints for GovCloud (US) regions in SDK