Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped aws sdk version for FIPS compliance #1043

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cs-simental
Copy link

Version 1.12.399 is the lowest version that enables FIPS endpoints for GovCloud (US) regions in SDK

Copy link
Contributor

@dbyron-sf dbyron-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this built. Until version 1.12.399 of https://github.com/Netflix/awsobjectmapper exists, I don't think this is gonna work. That repo is totally open to contributions though, so please make a PR there.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 9bb6e97: Bumped aws sdk version for FIPS compliance

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@cs-simental
Copy link
Author

@dbyron-sf made a pull request for https://github.com/Netflix/awsobjectmapper

Netflix/awsobjectmapper#116

do you know who I may reach to give a look to the request?

@dbyron-sf
Copy link
Contributor

Thanks. They're usually pretty prompt.

@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

update

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@armory-io needs to authorize modification on its head branch.
err-code: E3409

@dbyron-sf
Copy link
Contributor

@cs-simental could you rebase please? Also would be great if you can link to some docs showing 1.12.399 as the minimum version for govcloud fips compliance.

@cs-simental cs-simental force-pushed the BOB-31045-update_aws_sdk_and_cli branch from 623d8b7 to 9bb6e97 Compare April 17, 2023 22:20
@cs-simental cs-simental force-pushed the BOB-31045-update_aws_sdk_and_cli branch from 9bb6e97 to 65eae85 Compare April 17, 2023 22:24
@cs-simental
Copy link
Author

cs-simental commented Apr 17, 2023

@dbyron-sf rebased.

Link to FIPS documentation in aws-java-sdk:
https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md#112399-2023-02-02

@dbyron-sf
Copy link
Contributor

Thanks @cs-simental . Can you also let us know where you've tested this please.

@Avi1235
Copy link

Avi1235 commented Apr 20, 2023

Hello 👋 updating the sdk also helps with Configuring lambda SnapStart as it was introduced in 1.12.351

see issue: spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker#128

@mattgogerly
Copy link
Member

Hello 👋 updating the sdk also helps with Configuring lambda SnapStart as it was introduced in 1.12.351

see issue: spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker#128

Thanks for highlighting this - we're working on moving the Lambda plugin into the main codebase and snapstart was on my list of things to add once that effort was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants