Add Microsoft Teams notification #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeisukeYamashita
requested review from
ezimanyi and
maggieneterval
as code owners
Comment on lines
+4954
to
+4968
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
[note]
Theses are auto generated by the kleat-protobuilder. I ran make proto to generate these fields.
ezimanyi
approved these changes
Nov 16, 2020
|
@KeisukeYamashita I think we need to also update the echo message and translate the |
|
@maggieneterval Thanks for your quick review🙇♂️ Yeah, I totally missed that point, I will raise another PR🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I added
microsoftteamsfield for Microsoft Teams notification configuration which was added in the Spinnaker1.23.0release.The fields are same as the
halconfigdescribed here.Thanks in advance.
Why
It was missing.
Described in Microsoft Teams vs Slack: Which Collaboration App Is Better?, there are many Microsoft Teams adoption in the world. We should add them soon.
Ref