-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): use versions of dependencies that are available on maven central #1894
Conversation
@rvazquezglez or @zachsmith1 any chance you can make the okhttp/retrofit changes here similar to spinnaker/clouddriver@f11b7b7 ? |
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
@dbyron-sf sorry not following — what is needed here? |
Oh I think I know what happened. Will TAL tomorrow |
@dbyron-sf fixed the CF stuff but looks like there is another issue elsewhere |
…central now that bintray is gone (https://status.bintray.com/). Keep up with maven coordinate change from com.netflix.spinnaker to io.spinnaker.
instead of org.lognet:grpc-spring-boot-starter:2.3.2 since org.lognet:grpc-spring-boot-starter:2.3.2 isn't available at maven central.
since 1.71 isn't available at maven central. 1.72 is available, but doesn't compile. Update use of getMainParameter / getMainParameterValue now that getMainParameterValue needs a null check. Note that a transitive dependency elsewhere (org.testng:testng:6.13.1) expects version 1.72 of jcommander.
spinnaker#1894 brought in version 1.75 of com.beust:jcommander where we previously had 1.71. 1.75 includes cbeust/jcommander@192ec86 which adds additional arity validation, which causes halyard commands with main parameters that specify an arity to fail. I suspect it's a bug in jcommander, but... 1.75 also includes cbeust/jcommander@d51a5b7 which allows us to replace List<String> and arity of 1 with String, simplifying our code. It would be nice for jcommander's validation to handle the missing case, but this is still simpler than what we had before, and works. Bumping to 1.81 at the same time to stay up to date, and to demonstrate that specifying arity = 1 still doesn't work with 1.81, but these fixes do.
#1894 brought in version 1.75 of com.beust:jcommander where we previously had 1.71. 1.75 includes cbeust/jcommander@192ec86 which adds additional arity validation, which causes halyard commands with main parameters that specify an arity to fail. I suspect it's a bug in jcommander, but... 1.75 also includes cbeust/jcommander@d51a5b7 which allows us to replace List<String> and arity of 1 with String, simplifying our code. It would be nice for jcommander's validation to handle the missing case, but this is still simpler than what we had before, and works. Bumping to 1.81 at the same time to stay up to date, and to demonstrate that specifying arity = 1 still doesn't work with 1.81, but these fixes do.
This effectively combines the autobump PRs for clouddriver, fiat, front50, and spinnaker-gradle-project, along with the maven coordinate change from
com.netflix.spinnaker
toio.spinnaker
.There are also some other version changes to use dependencies that exist on maven central, though I haven't been able to exercise them much because...
There have been some changes to clouddriver-cloudfoundry that mean we need some tweaks here too. Or at least I get the following compiler errors: