Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(retrofit): remove all com.squareup.okhttp dependencies #1845

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kirangodishala
Copy link
Contributor

@kirangodishala kirangodishala commented Nov 13, 2024

All references to com.squareup.okhttp will be removed with this PR.

ApiExtensionController needed minor refactoring to fix the following error caused due to kotlin-java conflicts:

class java.lang.Object cannot be cast to class java.lang.String (java.lang.Object and java.lang.String are in module java.base of loader 'bootstrap')
  java.lang.ClassCastException: class java.lang.Object cannot be cast to class java.lang.String (java.lang.Object and java.lang.String are in module java.base of loader 'bootstrap')
  at com.netflix.spinnaker.gate.controllers.ApiExtensionController.any(ApiExtensionController.kt:80)
  at com.netflix.spinnaker.gate.controllers.ApiExtensionControllerTest$tests$1$3$2.invoke(ApiExtensionControllerTest.kt:61)
  at com.netflix.spinnaker.gate.controllers.ApiExtensionControllerTest$tests$1$3$2.invoke(ApiExtensionControllerTest.kt:59)

Refer spinnaker/kork#1210 for kork PR which completes the removal of okhttp2 dependencies.

Refactored a small snippet in ApiExtensionController to fix the ClassCastException caused due to kotlin-java conflicts
@kirangodishala kirangodishala marked this pull request as draft November 13, 2024 17:08
@kirangodishala kirangodishala marked this pull request as ready for review November 14, 2024 10:23
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Nov 14, 2024
@mergify mergify bot added the auto merged label Nov 14, 2024
@mergify mergify bot merged commit 1e706c0 into spinnaker:master Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants