Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spine Items changes related to ditching Dagster #204

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Apr 22, 2024

Re spine-tools/Spine-Toolbox#2523

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.74%. Comparing base (1ea1f1f) to head (1ec6075).

Files Patch % Lines
spine_items/db_writer_item_base.py 50.00% 1 Missing ⚠️
spine_items/exporter/exporter.py 50.00% 1 Missing ⚠️
spine_items/tool/tool.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           0.8-dev     #204      +/-   ##
===========================================
+ Coverage    61.71%   61.74%   +0.02%     
===========================================
  Files          190      190              
  Lines        17685    17687       +2     
  Branches      2897     2897              
===========================================
+ Hits         10914    10920       +6     
+ Misses        6187     6183       -4     
  Partials       584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptsavol ptsavol merged commit 18d8a92 into 0.8-dev Apr 25, 2024
9 of 11 checks passed
@ptsavol ptsavol deleted the issue_2523 branch April 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant