Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conforming to pylint #148

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conforming to pylint #148

merged 3 commits into from
Jul 25, 2024

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jul 25, 2024

No functional changes. Fixed the majority of warnings issued by pylint. Mainly the same warnings as mentioned in this PR are still around.

Checklist before merging

  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 57.28155% with 44 lines in your changes missing coverage. Please review.

Project coverage is 62.77%. Comparing base (18782a8) to head (84a90ca).

Files Patch % Lines
...ne/execution_managers/conda_kernel_spec_manager.py 0.00% 8 Missing ⚠️
...execution_managers/persistent_execution_manager.py 50.00% 5 Missing ⚠️
spine_engine/server/remote_execution_service.py 0.00% 4 Missing and 1 partial ⚠️
spine_engine/utils/queue_logger.py 37.50% 5 Missing ⚠️
spine_engine/server/engine_server.py 55.55% 4 Missing ⚠️
...ine/execution_managers/kernel_execution_manager.py 70.00% 3 Missing ⚠️
spine_engine/project_item/executable_item_base.py 0.00% 2 Missing ⚠️
spine_engine/server/certificate_creator.py 0.00% 2 Missing ⚠️
spine_engine/utils/serialization.py 0.00% 2 Missing ⚠️
...ine/execution_managers/conda_kernel_spec_runner.py 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   62.69%   62.77%   +0.07%     
==========================================
  Files          40       40              
  Lines        3855     3844      -11     
  Branches      767      766       -1     
==========================================
- Hits         2417     2413       -4     
+ Misses       1290     1283       -7     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 910e1c0 into master Jul 25, 2024
12 of 14 checks passed
@PiispaH PiispaH deleted the conforming_to_pylint branch July 25, 2024 07:52
ptsavol added a commit that referenced this pull request Jul 30, 2024
ptsavol added a commit that referenced this pull request Jul 30, 2024
This reverts commit 910e1c0.

This commit broke remote execution and the execution tests on Spine Toolbox side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant