Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift Python version upper limit #140

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

soininen
Copy link
Contributor

@soininen soininen commented May 15, 2024

This PR enables Spine-Engine to work with Python 3.12 and higher and removes dependencies that are no longer required since we dropped Dagster.

There is now a requirements.txt file that allows installing a self-contained Spine-Engine. It is not very useful without Spine-Items but it is there for completeness sake.

Developer dependencies can be installed by

python -mpip install -r dev-requirements.txt

if, for some strange reason, you want to develop a self-contained Spine-Engine package.

Re spine-tools/Spine-Toolbox#2522

Checklist before merging

  • Unit tests pass

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.86%. Comparing base (c0b583e) to head (553d9fc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   62.86%   62.86%           
=======================================
  Files          43       43           
  Lines        3886     3886           
  Branches      765      765           
=======================================
  Hits         2443     2443           
  Misses       1296     1296           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen force-pushed the toolbox_2522_enable_python_3.12 branch 3 times, most recently from eb07f5b to 4575140 Compare May 16, 2024 07:33
Cleaned up dependencies since Dagster is now gone.

Moved doc and dev requirements to pyproject.toml

Also, removed some auto-generated files in docs/source/autoapi
that were accidentally committed to the repo.

Re spine-tools/Spine-Toolbox#2522
@soininen soininen force-pushed the toolbox_2522_enable_python_3.12 branch from 4575140 to 553d9fc Compare May 16, 2024 07:35
@soininen soininen merged commit 0ad010f into master May 16, 2024
12 checks passed
@soininen soininen deleted the toolbox_2522_enable_python_3.12 branch May 16, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant