Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude PySide6 6.8.0 #2979

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Exclude PySide6 6.8.0 #2979

merged 1 commit into from
Oct 11, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Oct 11, 2024

This version of PySide6 makes Toolbox segfault on Windows.

Resolves #2978

Checklist before merging

  • Unit tests pass

This version of PySide6 makes Toolbox segfault on Windows.
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (36824c8) to head (fd0c9bf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
+ Coverage   66.91%   67.06%   +0.15%     
==========================================
  Files         190      190              
  Lines       37120    37120              
  Branches     5327     5327              
==========================================
+ Hits        24837    24896      +59     
+ Misses      11030    10963      -67     
- Partials     1253     1261       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit bdaac28 into master Oct 11, 2024
22 checks passed
@soininen soininen deleted the 2978_disable_pyside6_6.8.0 branch October 11, 2024 07:49
@ptsavol ptsavol mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbox segfaults on Windows with PySide6 6.8.0
1 participant