Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph view adding N-D entities traceback #2777

Merged
merged 1 commit into from
May 16, 2024

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented May 16, 2024

Fixed a bug that made the Connect entities -action in graph view not work.

Re #2772

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.76%. Comparing base (2e3ca53) to head (fac8711).

Files Patch % Lines
spinetoolbox/spine_db_icon_manager.py 0.00% 2 Missing and 1 partial ⚠️
spinetoolbox/spine_db_editor/graphics_items.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2777   +/-   ##
=======================================
  Coverage   65.76%   65.76%           
=======================================
  Files         196      196           
  Lines       35995    35998    +3     
  Branches     6118     6119    +1     
=======================================
+ Hits        23671    23673    +2     
- Misses      11055    11056    +1     
  Partials     1269     1269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit fc9a23b into master May 16, 2024
17 of 18 checks passed
@PiispaH PiispaH deleted the issue_2772_fix_adding_ND_entities_from_graph branch May 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant