Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fully collapsable widgets #2244

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Aug 10, 2023

Disabled fully collapsing widgets by setting every QSplitters childrenCollapsible property to false.

Fixes #2167

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Disabled fully collapsing widgets by setting every QSplitters childrenCollapsible property to false.

Re #2167
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (af55312) 63.81% compared to head (a5b9667) 63.79%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
- Coverage   63.81%   63.79%   -0.03%     
==========================================
  Files         198      198              
  Lines       35942    35947       +5     
  Branches     6114     5121     -993     
==========================================
- Hits        22937    22932       -5     
- Misses      11779    11790      +11     
+ Partials     1226     1225       -1     
Files Changed Coverage Δ
spinetoolbox/ui/array_editor.py 98.78% <100.00%> (+0.01%) ⬆️
spinetoolbox/ui/mini_kernel_editor_dialog.py 99.16% <100.00%> (+<0.01%) ⬆️
spinetoolbox/ui/settings.py 99.87% <100.00%> (+<0.01%) ⬆️
...etoolbox/ui/time_series_fixed_resolution_editor.py 98.82% <100.00%> (+0.01%) ⬆️
...olbox/ui/time_series_variable_resolution_editor.py 97.87% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 3b8cc7e into master Aug 10, 2023
@PiispaH PiispaH deleted the issue_2167_remove_fully_collapsable_widgets branch August 10, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of fully collapsible widgets
2 participants