Project level setting to disable execute project button #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soininen
force-pushed
the
2237_disableable_execute_project_button
branch
from
da50b13 to
de11f98
Compare
- Renamed SpineToolboxProject.settings to app_settings, since settings now means project-level settings - Implemented a ProjectSettings class which holds the settings - The settings are now stored in project.json bumping LATEST_PROJECT_VERSION to 11 - The only project setting available is enable_execute_all which enables or disables the Execute Project button. - Implemented the enable_execute_all setting - Improved tooltips on the execute buttons Currently, there is no interface in Toolbox to change the project settings so it must be done through editing project.json by hand. This is intended. Re #2237
soininen
force-pushed
the
2237_disableable_execute_project_button
branch
from
de11f98 to
5aec09b
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2238 +/- ##
==========================================
+ Coverage 63.79% 63.81% +0.01%
==========================================
Files 197 198 +1
Lines 35895 35942 +47
Branches 6104 6114 +10
==========================================
+ Hits 22901 22937 +36
- Misses 11772 11779 +7
- Partials 1222 1226 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a project-level setting to disable the Execute Project button and bumps
project.jsonversion to 11. The setting is currently editable only via editingproject.jsonby hand.Resolves #2237
Checklist before merging