Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to a post-Dagster world #405

Merged
merged 1 commit into from
May 16, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented May 15, 2024

Spine Engine doesn't use Dagster anymore, so we need not restrict spinedb_api dependencies anymore.

All spinedb_api's dependencies are now in pyproject.toml and can be installed e.g. in editable mode by

python -mpip install -e .

Developer and documentation dependencies can now be installed from a single dev-requirements.txt file:

python -mpip install -r dev-requirements.txt

Re spine-tools/Spine-Toolbox#2522

Checklist before merging

  • Unit tests pass

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (2e5576f) to head (f84526d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   78.22%   78.21%   -0.02%     
==========================================
  Files          76       76              
  Lines        9509     9509              
  Branches     2016     2016              
==========================================
- Hits         7438     7437       -1     
- Misses       1736     1737       +1     
  Partials      335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen force-pushed the toolbox_2522_enable_python_3.12 branch 5 times, most recently from f743af7 to 1bc3699 Compare May 16, 2024 06:44
Spine Engine doesn't use Dagster anymore, so we need not restrict
spinedb_api dependencies anymore.

Developer and documentation dependencies can now be installed
by a single dev-requirements.txt file.

Re spine-tools/Spine-Toolbox#2522
@soininen soininen force-pushed the toolbox_2522_enable_python_3.12 branch from 1bc3699 to f84526d Compare May 16, 2024 07:23
@soininen soininen merged commit 283f844 into master May 16, 2024
13 of 14 checks passed
@soininen soininen deleted the toolbox_2522_enable_python_3.12 branch May 16, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant