Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve expect crashes #311

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Resolve expect crashes #311

merged 5 commits into from
Oct 9, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 9, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Resolves issues eldritch usage of expect which causes the process to panic.
  • Removes dangerous calls to unwrap in eldritch

imixcrash

Which issue(s) this PR fixes:

@hulto hulto added bug Something isn't working eldritch Related to the Eldritch language labels Oct 9, 2023
@hulto hulto added this to the minor fixes before IRSEC milestone Oct 9, 2023
@hulto hulto requested a review from jabbate19 October 9, 2023 22:01
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #311 (5446ec4) into main (e572473) will increase coverage by 0.06%.
The diff coverage is 90.66%.

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   74.83%   74.90%   +0.06%     
==========================================
  Files          94       94              
  Lines        6116     6112       -4     
==========================================
+ Hits         4577     4578       +1     
+ Misses       1452     1447       -5     
  Partials       87       87              
Files Coverage Δ
implants/lib/eldritch/src/file/compress_impl.rs 88.99% <100.00%> (+0.99%) ⬆️
implants/lib/eldritch/src/file/download_impl.rs 97.82% <100.00%> (-0.22%) ⬇️
implants/lib/eldritch/src/file/list_impl.rs 94.28% <100.00%> (ø)
implants/lib/eldritch/src/file/replace_all_impl.rs 100.00% <100.00%> (ø)
implants/lib/eldritch/src/pivot/arp_scan_impl.rs 44.23% <100.00%> (+1.04%) ⬆️
implants/lib/eldritch/src/process/list_impl.rs 86.15% <100.00%> (ø)
implants/lib/eldritch/src/sys/get_ip_impl.rs 98.66% <100.00%> (ø)
implants/lib/eldritch/src/sys/get_os_impl.rs 97.22% <100.00%> (ø)
implants/lib/eldritch/src/sys/shell_impl.rs 95.87% <100.00%> (-0.13%) ⬇️
implants/lib/eldritch/src/pivot/ncat_impl.rs 81.65% <66.66%> (+1.47%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hulto hulto merged commit 9283c23 into main Oct 9, 2023
8 checks passed
@hulto hulto deleted the resolve-expect-crashes branch October 9, 2023 23:51
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Resolve expect crashes (#311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eldritch Related to the Eldritch language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants