Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tavern Fixes & Cleanup #308

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Tavern Fixes & Cleanup #308

merged 4 commits into from
Oct 5, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind cleanup
/kind bug

What this PR does / why we need it:

  • Fixes code generation
  • Cleanup embedded UI assets
  • Cleanup UI serving
  • Cleanup metadata.yml parsing

@KCarretto KCarretto requested a review from hulto October 5, 2023 22:53
hulto
hulto approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #308 (67c1b7a) into main (d29a4a0) will increase coverage by 0.04%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   74.80%   74.84%   +0.04%     
==========================================
  Files          94       94              
  Lines        6131     6117      -14     
==========================================
- Hits         4586     4578       -8     
+ Misses       1458     1452       -6     
  Partials       87       87
Files Coverage Δ
tavern/app.go 56.89% <100.00%> (-0.37%) ⬇️
tavern/tomes/parse.go 51.31% <66.66%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KCarretto KCarretto merged commit bf08fd1 into main Oct 5, 2023
8 checks passed
@KCarretto KCarretto deleted the www-fixes branch October 5, 2023 23:31
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
4aa85b5 
 
Tavern Fixes & Cleanup (#308)

* Cleanup HTTP Handler Code

* Fix tavern/ent go generate

* fix http ui embedding

* cleanup metadata.yml parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KCarretto @hulto