Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev container plugins #303

Merged
merged 13 commits into from
Nov 20, 2023
Merged

Update dev container plugins #303

merged 13 commits into from
Nov 20, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 4, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Not a fan of the vscode icons makes it kinda hard to read - would prefer to leave this an opt in thing for folks.

Which issue(s) this PR fixes:

@hulto hulto added cleanup Code cleanup and tech debt removal dev-ops labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (283b768) 74.94% compared to head (fbec060) 74.91%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   74.94%   74.91%   -0.03%     
==========================================
  Files         104      104              
  Lines        6893     6893              
==========================================
- Hits         5166     5164       -2     
- Misses       1631     1633       +2     
  Partials       96       96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto changed the title Resolve stash pop Update dev container plugins Oct 5, 2023
@hulto hulto requested a review from KCarretto October 28, 2023 20:21
Cictrone
Cictrone approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>:(

@hulto hulto merged commit 1b73469 into main Nov 20, 2023
6 checks passed
@hulto hulto deleted the update-dev-container branch November 20, 2023 04:26
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
2a422cb 
 
Update dev container plugins (#303)

* Disable vscode icons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone approved these changes

@KCarretto KCarretto Awaiting requested review from KCarretto

Assignees
No one assigned
Labels
cleanup Code cleanup and tech debt removal dev-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hulto @Cictrone