Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gym version to fix conflict with newer version of setuptools module #286

Merged
merged 1 commit into from
May 21, 2024

Conversation

RachithP
Copy link
Collaborator

@RachithP RachithP commented May 20, 2024

gym==0.21.0 has conflicts with setuptools>65.5.0 (openai/gym#3176). In order to resolve this issue,

  1. the setuptools version must be downgraded, as the default version with python3.8 using conda is 69.5.1. Also, the version of wheels must be downgraded to below 0.40.0 as noted here
  2. gym must be upgraded. Since, gym upgrade to 0.23.0 (https://github.com/openai/gym/releases/tag/0.23.1) has no breaking API changes,

I prefer this option 2 as it's better to upgrade modules rather than downgrading, and this option has the least code changes.

@RachithP RachithP requested a review from mikeroberts3000 May 20, 2024 20:53
@mikeroberts3000
Copy link
Collaborator

100% agree with your reasoning. And we're barely using gym for anything anyway, so even if there were a lot of breaking API changes in the new gym version, I'd be surprised if we would be affected.

@RachithP RachithP merged commit a9a3f29 into main May 21, 2024
@RachithP RachithP deleted the rachithp/fixes branch May 21, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants