Simplify parsing ceildiv/floordiv/mod #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to reproduce the problem described in these comments:
This PR removes this transformation step.
I did run into a similar problem where
arith.constant 0 : index
was being parsed asarith.constant0
. The root issue was inbare_id
. I solved it by inlining the regexes, and introducingplain_id
:... and then replacing each instance of
bare_id "." bare_id
withplain_id "." plain_id
. I can submit that as a PR if you'd like.