Bump xerces version to 2.12.2 #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm on vacation for a few days but will take a look as soon as I
can.
Note that I had #2441 open to track this work, and there are some related
issues I'm working through with the java dependencies more generally (see
#2436 and #2437) which aren't blocked but I would like to try to fix it all
before making a release.
…On Tue, Mar 22, 2022, 6:28 AM João Duarte ***@***.***> wrote:
*What problem is this PR intended to solve?*
XercesJ 2.12.2 is a bugfix release that includes important fixes,
including a parsing performance issue and a bug in the regex implementation.
*Does this change affect the behavior of either the C or the Java
implementations?*
This change should only fix bugs in the Java execution and there should be
no changes in behavior.
------------------------------
You can view, comment on, or merge this pull request online at:
#2482
Commit Summary
- 19263b3
<19263b3>
Bump xerces version to 2.12.2
File Changes
(2 files <https://github.com/sparklemotion/nokogiri/pull/2482/files>)
- *M* lib/nokogiri/jruby/nokogiri_jars.rb
<https://github.com/sparklemotion/nokogiri/pull/2482/files#diff-dd5b46f48b38927168b8975c28b17ed4e521983c5a439738724a243530c516dc>
(6)
- *M* nokogiri.gemspec
<https://github.com/sparklemotion/nokogiri/pull/2482/files#diff-2df1360f67f1e94efbe53163b7a4188e34f07eb2691a16b20de14a7757ed7008>
(4)
Patch Links:
- https://github.com/sparklemotion/nokogiri/pull/2482.patch
- https://github.com/sparklemotion/nokogiri/pull/2482.diff
—
Reply to this email directly, view it on GitHub
<#2482>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACAD4GW2VSRCCF7EF2H4TVBGOE3ANCNFSM5RKNM6GQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
flavorjones
force-pushed
the
xerces_2_12_2
branch
from
19263b3 to
9cd7a21
Compare
|
Thanks again for this contribution! I've added a couple of commits to update the jar files, rebase onto main, and update the CHANGELOG. If this goes green, I'll merge and it will be in v1.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
XercesJ 2.12.2 is a bugfix release that includes important fixes, including a parsing performance issue and a bug in the regex implementation.
Does this change affect the behavior of either the C or the Java implementations?
This change should only fix bugs in the Java execution and there should be no changes in behavior.