Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Unpin tox #345

Merged
merged 3 commits into from
Dec 27, 2022
Merged

TST: Unpin tox #345

merged 3 commits into from
Dec 27, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 27, 2022

Description

This pull request is to fix #344

Also other changes to be consistent with spacetelescope/stsynphot_refactor#173

@pllim pllim added this to the 1.2.0 milestone Dec 27, 2022
@pllim pllim added the testing label Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 97.08% // Head: 97.08% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5d95783) compared to base (bdbadba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   97.08%   97.08%   -0.01%     
==========================================
  Files          17       17              
  Lines        2024     2023       -1     
==========================================
- Hits         1965     1964       -1     
  Misses         59       59              
Impacted Files Coverage Δ
synphot/binning.py 91.87% <100.00%> (ø)
synphot/blackbody.py 72.88% <100.00%> (ø)
synphot/models.py 95.75% <100.00%> (ø)
synphot/observation.py 99.06% <100.00%> (ø)
synphot/reddening.py 99.00% <100.00%> (ø)
synphot/specio.py 99.09% <100.00%> (-0.01%) ⬇️
synphot/spectrum.py 99.49% <100.00%> (ø)
synphot/thermal.py 100.00% <100.00%> (ø)
synphot/units.py 97.54% <100.00%> (ø)
synphot/utils.py 99.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim marked this pull request as ready for review December 27, 2022 22:31
@pllim pllim merged commit 5f26907 into spacetelescope:master Dec 27, 2022
@pllim pllim deleted the unpin-tox branch December 27, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Unpin tox<4 when we can
1 participant