Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Compatibility with astropy>=5 #321

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 25, 2021

Description

This pull request is to address compatibility problem with astropy>=5.0, specifically astropy/astropy#11930 .

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #321 (4241c1f) into master (760225e) will decrease coverage by 0.08%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   94.40%   94.31%   -0.09%     
==========================================
  Files          14       14              
  Lines        2000     2005       +5     
==========================================
+ Hits         1888     1891       +3     
- Misses        112      114       +2     
Impacted Files Coverage Δ
synphot/models.py 84.81% <71.42%> (-0.37%) ⬇️
synphot/compat.py 77.77% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760225e...4241c1f. Read the comment docs.

@pllim pllim merged commit c5f0b7a into spacetelescope:master Oct 25, 2021
@pllim pllim deleted the astropy-5.0-compat branch October 25, 2021 20:23
pllim added a commit that referenced this pull request Oct 25, 2021
@pllim pllim modified the milestones: 1.2.0, 1.1.1 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant