ENH: Integrate with dust-extinction API #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
commented
Feb 21, 2020
karllark
reviewed
Feb 21, 2020
|
@karllark , is this sufficient? It looks like |
|
Looks great. |
|
Okay, good to know. Can you please formally approve if you are okay with this being merged? If not, please let me know what else is needed. Thank you! |
karllark
approved these changes
Feb 24, 2020
This was referenced Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #132
p.s. Sorry, Karl, no
__mul__magic needed after all. 😉TODO
dust-extinctiondoc once DOC: Add a Sphinx ref to main title karllark/dust_extinction#144 is merged and deployed.astropy-tutorialsas a reminder to update Color Excess tutorial with this API in the future. See Color-excess tutorial to use new API in synphot 0.3 astropy/astropy-tutorials#433