Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download helper function #179

Merged
merged 2 commits into from
Mar 23, 2019
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 22, 2019

Fix #178

TODO:

  • Write tests
  • Test on Linux
  • Test on Windows (Appveyor)
  • Update docs to get rid of FTP instructions and use this function instead

@pllim pllim added this to the 0.1.3 milestone Mar 22, 2019
@pllim pllim self-assigned this Mar 22, 2019
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #179 into master will decrease coverage by 0.06%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage      97%   96.93%   -0.07%     
==========================================
  Files          13       13              
  Lines        1705     1732      +27     
==========================================
+ Hits         1654     1679      +25     
- Misses         51       53       +2
Impacted Files Coverage Δ
synphot/utils.py 97.91% <92.59%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78ddb3...e5ad3d6. Read the comment docs.

@pllim pllim merged commit c21a04d into spacetelescope:master Mar 23, 2019
@pllim pllim deleted the download-helper branch March 23, 2019 14:54
pllim added a commit that referenced this pull request Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant