Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Python 3.8 #451

Merged
merged 5 commits into from
May 4, 2023
Merged

Conversation

zacharyburnett
Copy link
Collaborator

Numpy is imminently dropping support for Python 3.8

@zacharyburnett zacharyburnett self-assigned this Apr 14, 2023
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 14, 2023 15:50
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eec9a2b) 86.91% compared to head (4f86221) 86.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          23       23           
  Lines        3868     3868           
=======================================
  Hits         3362     3362           
  Misses        506      506           
Flag Coverage Δ
unit 86.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nden
Copy link
Collaborator

nden commented May 4, 2023

@zacharyburnett The documentation build is failing on this one. Can you fix it?

@nden
Copy link
Collaborator

nden commented May 4, 2023

Could you also apply the fix from #447?

@nden nden merged commit 2fb4809 into spacetelescope:master May 4, 2023
@zacharyburnett zacharyburnett deleted the drop_py38 branch May 4, 2023 18:32
@nden nden added this to the 0.19 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants