Fix build for m1 #149
Open
Fix build for m1 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add Equal method to compare keys
feat: add freebsd support
This allows us to determine the size of signatures produced by a public key. Incidentally, this also allows us to determine the size of an RSA key's modulus.
feat: add Size function to PublicKey
pass build flags on Solaris/Illumos
Signed-off-by: Tiger <[email protected]>
Signed-off-by: Tiger <[email protected]>
…j_identifier add binding for OBJ_create
- add support to retrive custom extension value - add support to add custom protocol for protocol negotiation Signed-off-by: Tiger <[email protected]>
…laji/create_obj_identifier
Signed-off-by: Tiger <[email protected]>
Signed-off-by: Tiger <[email protected]>
Add required bindings to support openssl in libp2p-tls
…special make ed25519 less special
…; made PEM file splitter tolerant of trailing whitespace in PEM block delimiter lines
Enabled PEM files with CRLF line endings to be used (spacemonkeygo#10)
Fix `staticcheck` issues: - S1028 use `fmt.Errorf` to construct formatted errors - ST1017 yoda conditions - ST1005 error message capitalization - ST1006 avoid `self` as receiver name - S1030 use `buf.String` - S1011 avoid redundant loop when `append` suffices - SA4006 unused value - S1019 remove redundant capacity on `make` call - SA2002 `t.Fatal` called outside of test Exported error violates ST1012, which is ignored by this PR since rename may cause breaking changes. Remove redundant parentheses wrapping, and use CamelCase naming while at it.
Address `staticcheck` issues
Tests fail due to weak MD on self-signed RSA cert: update from SHA-1 to SHA-2
Closing may need to write, which will cause it to fail if the other side has already closed. The correct fix is to use shutdown to half-close, then wait for the other side, but that's honestly not worth it right now. So I just fixed the tests to pass.
Update test RSA cert
ci: add go-test-setup action
sync: update CI config files
- this is an analog for net.DialTimeout call - the timeout is only for net.Dial call - the timeout does not include OpenSSL calls
- Ctx.SetMinProtoVersion wraps SSL_CTX_set_min_proto_version - Ctx.SetMaxProtoVersion wraps SSL_CTX_set_max_proto_version
…_max_proto_version Add Ctx.SetMinProtoVersion and Ctx.SetMaxProtoVersion wrappers
…eout-call Add openssl.DialTimeout(network, addr, timeout, ctx, flags) call
Install mingw toolchain on windows machines for go test
sync: update CI config files
FirePhenix
approved these changes
Jun 10, 2022
|
sorry, I clicked the wrong button and approved it, it's not my repo. |
* Fix build with OpenSSL 3.0 - FIPS_mode_set() does not exist in OpenSSL 3.0 [1] - X509_check_* functions declarated in openssl/x509v3.h instead of openssl/x509.h [2] - X509_chack_* functions have const char arg inserad of const unsigned char [2] - skip MD4 tests if it is unsupported by OpenSSL - the patch does not change behavior under OpenSSL version != 3 - the patch just fixes build under OpenSSL 3.0 and doesn't update deprecated code or behavior 1. https://wiki.openssl.org/index.php/OpenSSL_3.0#Upgrading_from_the_OpenSSL_2.0_FIPS_Object_Module 2. https://www.openssl.org/docs/man3.0/man3/X509_check_host.html * Add Ubuntu 22.04 runner to GitHub Actions go test workflow * Fix flaky tests on Ubuntu 22.04 It is necessary to handle OpenSSL errors very carefully. Otherwise, errors may appear in unexpected places. For example, we didn't catch an error from EVP_DigestInit_ex() and it appears sometimes in conn.go: func (c *Conn) getErrorHandler(rv C.int, errno error) func() error { errcode := C.SSL_get_error(c.ssl, rv) // <- here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openssl is installed in different location for macbook with m1, I added build constraints to fix this