Fix travis #63
Merged
Fix travis #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only test on nightly and *ignore* the result! Since it should build witout problem on 1.15.1 onwards, we enable these.
|
Hm, somehow clippy still doesn't work. Btw, alternatively there's now a "cargo clippy" subcommand available, instead of conditional compilation. |
I think it's just that it's currently broken for the latest nightly... Maybe we should use a star dependency? Or at least "^0.0" so we always have the latest clippy with the latest nightly which should work. See https://github.com/Manishearth/rust-clippy#usage |
|
Agree, let's use " |
Clippy only guarantees, that the latest clippy version will work with the latest nightly build of Rust. So we want to always use the latest version.
|
Regarding the clippy failure: See https://github.com/Manishearth/rust-clippy/pull/1833 and https://github.com/Manishearth/rust-clippy/issues/1834 |
|
@dbrgn OK like that? |
dbrgn
requested changes
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our travis pipeline is more or less useless, since we only build on nighlty which fails, but we ignore the result.