use setup_logger in content_generator.py

[druce]

Was having trouble with adding some logging in content_generator.py

I think it should use setup_logger to use same config.yaml settings as client.py, anyway not sure why they should be different.

Anyway after making the change I can add logger.debug statements in content_generator.py and they work as expected.

[souzatharsis]

@druce I am afraid it is not best practice to use two different logging packages in the same project.

[druce]

no worries Tharsis, I am sure any way you do it is great, I was adding some log statements to understand better and having an issue with log statements in content_generator.py not working, like "logger.debug(f"Prompt params: \n{prompt_params}")" I can think of 2 ways to do it 1) have a logging.py module , which creates a logger object , in each file use from logging import logger this creates a single logger object accessible to each file, it's kind of the way I've usually done it 2) have a setup_logger.py which is what I think you had in client.py , in each file call logger = setup_logger(__name__) so since that looked like your preference I was thinking should call setup_logger() in content_generator.py too? but yeah, you end up with one logger object per file which is maybe not ideal , on the other hand you have different __name__ for each logger, could potentially have different debug levels per file was just something I did to get some additional log output, it didn't seem to work as expected the way it was set up, but I might have missed something.

…

On Sun, Nov 24, 2024 at 7:06 PM Tharsis Souza ***@***.***> wrote: @druce <https://github.com/druce> I am afraid it is not best practice to use two different logging packages in the same project. — Reply to this email directly, view it on GitHub <#186 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJDX3WRGMMFLPUDAMQPROL2CJSZDAVCNFSM6AAAAABR6U4N2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGQZTMMRWGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[druce]

possibly the reason I didn't get debug messages as expected was, I turned on debug in the config.yaml, but any files that didn't use setup_logger() don't read the YAML log param. so had default debug level.

so one solution was to use setup_logger for all logging ... seemed similar to instantiating logger in each file, except it uses the same methodology and reads the config.yaml, didn't see why client.py does it one way and other files do it the other ... although I could see maybe never want users to affect logging level and see debug messages in those files, only want devs to set level in the code while debugging.