Proposal: Add a new diagnostic type: NoMethodByNil #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
NoMethodByNil
branch
2 times, most recently
from
d7a79db to
bae8066
Compare
Add a new diagnostic type; NoMethodByNil, that is emitted to no method calls for the objects having optional types. It's separated from NoMethod to control the visiblity of these diagnostics individually. It's useful to find the methods not having appropriate types on checking the Ruby application by filtering NoMethod diagnostics.
tk0miya
force-pushed
the
NoMethodByNil
branch
from
bae8066 to
7fc6ae4
Compare
tk0miya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new diagnostic type; NoMethodByNil, that is emitted to no method calls for the objects having optional types. It's separated from NoMethod to control the visiblity of these diagnostics individually.
It's useful to find the methods not having appropriate types on checking the Ruby application by filtering NoMethod diagnostics.