-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playing with MQF #772
Playing with MQF #772
Conversation
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 29 29
Lines 4554 4554
Branches 46 46
=======================================
Hits 4075 4075
Misses 476 476
Partials 3 3 Continue to review full report at Codecov.
|
...are we bypassing reviews now, or is this a "doesn't actually affect sourmash functionality ATM" merge? :) |
I've been merging rust-only branches, do you want to review them? |
I've also trying to bring down my branches/PR count, too much work on keeping everything in sync... |
This PR implements a new SBT using MQFs as internal nodes, based on the rust_ffi branch at the MQF repo.
(it was also driving what features to expose initially on the MQF wrapper).
Since there is no index building implemented in Rust yet, https://github.com/dib-lab/sourmash/compare/rust/mqf_sketch?expand=1#diff-7154331bd19ac9d7b71a5499ac5955a8 is building the internal nodes explicitly (and will serve as reference for when index building is actually implemented).
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?