Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in MinHash.intersection. #687

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Fix memory leak in MinHash.intersection. #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sourmash/_minhash.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,10 @@ cdef class MinHash(object):
common.intersection_update(other.get_mins())
common.intersection_update(combined_mh.mins)

return common, max(combined_mh.size(), 1)
size = max(combined_mh.size(), 1)
del combined_mh

return common, size

def compare(self, MinHash other):
common, size = self.intersection(other)
Expand Down