Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving loading and save sigs to Rust #532

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Moving loading and save sigs to Rust #532

merged 2 commits into from
Jan 15, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Aug 16, 2018 •
edited
Loading

Remove dependency on ijson.

This also helps bridge the Index abc in Python to the Index trait in Rust, since they both take Signatures (which are defined in Rust with this PR).

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@luizirber luizirber added the rust label Aug 16, 2018
@olgabot olgabot mentioned this pull request Sep 17, 2018
Open
@luizirber luizirber force-pushed the rust_sig branch 4 times, most recently from 4ddf31c to d0f9aa0 Compare October 5, 2018 02:02
@luizirber luizirber changed the base branch from core/rust to master October 17, 2018 00:59
@luizirber luizirber force-pushed the rust_sig branch 6 times, most recently from 99ba8ef to e805f1e Compare December 10, 2018 22:24
@luizirber luizirber mentioned this pull request Dec 14, 2018
Merged
5 tasks
@luizirber luizirber changed the base branch from master to core/rust December 24, 2018 02:39
@luizirber luizirber force-pushed the core/rust branch 8 times, most recently from 09fc195 to 9db60c2 Compare December 28, 2018 22:43
@luizirber luizirber force-pushed the rust_sig branch 5 times, most recently from 9a06e53 to 6adfda9 Compare December 30, 2019 00:43
@luizirber luizirber changed the title [WIP] Moving loading and save sigs to rust [MRG] Moving loading and save sigs to rust Dec 30, 2019
@luizirber luizirber added this to the post-3.0 milestone Dec 30, 2019
@luizirber luizirber force-pushed the rust_sig branch 2 times, most recently from 4a98845 to 7c16ae7 Compare January 5, 2020 22:03
@luizirber luizirber changed the title [MRG] Moving loading and save sigs to rust Moving loading and save sigs to Rust Jan 7, 2020
@luizirber luizirber force-pushed the rust_sig branch 2 times, most recently from 7c8a2a7 to 3d28e61 Compare January 7, 2020 04:53
@luizirber luizirber mentioned this pull request Jan 7, 2020
Closed
@luizirber luizirber force-pushed the rust_sig branch 4 times, most recently from 74c3d1b to 64d9f14 Compare January 14, 2020 19:31
@luizirber luizirber modified the milestones: post-3.0, 3.1 Jan 14, 2020
This was referenced Jan 14, 2020
Merged
Closed
@luizirber
Moving loading and save sigs to rust
0cfde64 
move json parsing and init to rust
working on loading sigs
enable pickling for signatures
sort mins and abunds
remove dead code
remove refs
ctb
ctb approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@luizirber luizirber merged commit 2f05b07 into master Jan 15, 2020
@luizirber luizirber deleted the rust_sig branch January 15, 2020 18:12
@ctb ctb mentioned this pull request Jul 18, 2020
Closed
4 tasks
@luizirber luizirber mentioned this pull request Aug 11, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctb ctb ctb approved these changes

Assignees
No one assigned
Labels
ready for merge! rust
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@luizirber @ctb