Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend conda section #427

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Extend conda section #427

merged 2 commits into from
Feb 27, 2018

Conversation

druvus
Copy link
Contributor

@druvus druvus commented Feb 27, 2018

I added additional information about the conda install. It is important to setup channels correctly in advance to be able to use the conda install command. An alternative is to add channels together with the install command using -c.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

I added additional information about the conda install. It is important to setup channels correctly in advance to be able to use the conda install command. An alternative is to add channels together with the install command using `-c`.
@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          32       32           
  Lines        4824     4824           
  Branches       36       36           
=======================================
  Hits         4345     4345           
  Misses        478      478           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e503b...32ec868. Read the comment docs.

@luizirber luizirber merged commit a5c60c7 into sourmash-bio:master Feb 27, 2018
@luizirber
Copy link
Member

Thanks @druvus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants