-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use a Nodegraph for searching in internal nodes #395
Conversation
4cc1166
to
12efcf3
Compare
12efcf3
to
329aefa
Compare
329aefa
to
b8dcd14
Compare
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
- Coverage 89.47% 89.39% -0.09%
==========================================
Files 27 27
Lines 4238 4242 +4
Branches 39 39
==========================================
Hits 3792 3792
- Misses 446 450 +4
Continue to review full report at Codecov.
|
Turns out that this... works. Tests are failing because this depends on an unreleased branch of khmer, which dropped Python 2.7. Still need to run some benchmarks with real SBT indexes, only tried with a small subset of genbank (it's 30% faster, I suspect it will even better with large indexes) |
ae0ea4a
to
1df46cc
Compare
66e6edc
to
a21dcf2
Compare
a21dcf2
to
482f159
Compare
There are better ways of doing this once #424 is merged (including not depending on khmer releases). |
Direct similarity calculation of Nodegraphs avoid calling
get_mins
and copying then from C++ to Python all the time...Depends on dib-lab/khmer#1842 (and updating our dependency on khmer to
3.0+
)make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?