Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use a Nodegraph for searching in internal nodes #395

Closed
wants to merge 5 commits into from

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Feb 15, 2018

Direct similarity calculation of Nodegraphs avoid calling get_mins and copying then from C++ to Python all the time...

Depends on dib-lab/khmer#1842 (and updating our dependency on khmer to 3.0+)

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@luizirber luizirber force-pushed the feature/bf_query branch 2 times, most recently from 4cc1166 to 12efcf3 Compare February 18, 2018 23:45
@luizirber luizirber mentioned this pull request Feb 19, 2018
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #395 into master will decrease coverage by 0.08%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   89.47%   89.39%   -0.09%     
==========================================
  Files          27       27              
  Lines        4238     4242       +4     
  Branches       39       39              
==========================================
  Hits         3792     3792              
- Misses        446      450       +4
Impacted Files Coverage Δ
sourmash/sbtmh.py 85.51% <83.33%> (+0.51%) ⬆️
sourmash/signature_json.py 95.62% <0%> (-1.25%) ⬇️
sourmash/lca/lca_utils.py 95.23% <0%> (-0.8%) ⬇️
sourmash/lca/command_index.py 90.3% <0%> (-0.45%) ⬇️
sourmash/sbt.py 85.71% <0%> (ø) ⬆️
sourmash/sbt_storage.py 96.59% <0%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30b915...482f159. Read the comment docs.

@luizirber
Copy link
Member Author

luizirber commented Jan 4, 2019

Turns out that this... works. Tests are failing because this depends on an unreleased branch of khmer, which dropped Python 2.7.

Still need to run some benchmarks with real SBT indexes, only tried with a small subset of genbank (it's 30% faster, I suspect it will even better with large indexes)

taylorreiter added a commit that referenced this pull request Jan 11, 2019
@luizirber luizirber force-pushed the feature/bf_query branch 2 times, most recently from 66e6edc to a21dcf2 Compare January 11, 2019 18:43
@luizirber
Copy link
Member Author

There are better ways of doing this once #424 is merged (including not depending on khmer releases).

@luizirber luizirber closed this Nov 22, 2019
@luizirber luizirber deleted the feature/bf_query branch November 22, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant