Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add lca convert command #2000

Open
wants to merge 284 commits into
base: latest
Choose a base branch
from
Open

[WIP] add lca convert command #2000

wants to merge 284 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 26, 2022

Fixes #1961.

May update to tackle #1959 and/or #1964, too.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2000 (92f2fcd) into add/sqlite_index (9e616dd) will increase coverage by 7.35%.
The diff coverage is 61.42%.

@@                 Coverage Diff                  @@
##           add/sqlite_index    #2000      +/-   ##
====================================================
+ Coverage             83.99%   91.35%   +7.35%     
====================================================
  Files                   129      100      -29     
  Lines                 14937    10714    -4223     
  Branches               2079     2087       +8     
====================================================
- Hits                  12547     9788    -2759     
+ Misses                 2095      629    -1466     
- Partials                295      297       +2     
Flag Coverage Δ
python 91.35% <61.42%> (-0.21%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/lca/command_convert.py 35.48% <35.48%> (ø)
src/sourmash/index/sqlite_index.py 90.92% <44.44%> (-0.81%) ⬇️
src/sourmash/cli/lca/convert.py 85.71% <85.71%> (ø)
src/sourmash/cli/lca/__init__.py 100.00% <100.00%> (ø)
src/sourmash/lca/__init__.py 100.00% <100.00%> (ø)
src/sourmash/lca/command_index.py 89.60% <100.00%> (-0.30%) ⬇️
src/sourmash/lca/lca_db.py 93.43% <100.00%> (+0.15%) ⬆️
src/core/src/ffi/storage.rs
src/core/src/index/search.rs
src/core/src/sketch/nodegraph.rs
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e616dd...92f2fcd. Read the comment docs.

Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@mr-eyes
Copy link
Member

mr-eyes commented Apr 26, 2022

I haven't noticed tests for lca_convert, though.

@mr-eyes

This comment was marked as outdated.

@mr-eyes mr-eyes self-requested a review April 26, 2022 23:25
Base automatically changed from add/sqlite_index to latest April 26, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add an lca convert command
2 participants