-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add lca convert
command
#2000
base: latest
Are you sure you want to change the base?
Conversation
…o add/sqlite_index
…urmash into add/sqlite_index
…o add/sqlite_index
…o add/sqlite_index
…urmash into add/sqlite_index
Co-authored-by: Mohamed Abuelanin <[email protected]>
…o add/sqlite_index
…o add/sqlite_index
…o add/sqlite_index
Codecov Report
@@ Coverage Diff @@
## add/sqlite_index #2000 +/- ##
====================================================
+ Coverage 83.99% 91.35% +7.35%
====================================================
Files 129 100 -29
Lines 14937 10714 -4223
Branches 2079 2087 +8
====================================================
- Hits 12547 9788 -2759
+ Misses 2095 629 -1466
- Partials 295 297 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
I haven't noticed tests for |
Fixes #1961.
May update to tackle #1959 and/or #1964, too.