Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Rename sourmash_lib to sourmash #164

Closed
wants to merge 3 commits into from
Closed

Conversation

luizirber
Copy link
Member

Fixes #162

I had to change the runscript to take entry-points into account, we might want to port this to khmer too (for oxli?)

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Apr 11, 2017

Codecov Report

Merging #164 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   85.52%   85.49%   -0.04%     
==========================================
  Files          13       12       -1     
  Lines        1879     1875       -4     
  Branches       52       52              
==========================================
- Hits         1607     1603       -4     
  Misses        263      263              
  Partials        9        9
Impacted Files Coverage Δ
sourmash/sourmash_args.py 93.24% <ø> (ø)
sourmash/fig.py 86.84% <ø> (ø)
sourmash/logging.py 100% <ø> (ø)
sourmash/__main__.py 100% <ø> (ø)
sourmash/__init__.py 100% <ø> (ø)
sourmash/kmer_min_hash.hh 90.28% <ø> (ø)
sourmash/sbt.py 83.03% <ø> (ø)
sourmash/commands.py 89.44% <100%> (ø)
sourmash/signature.py 88.33% <100%> (ø)
sourmash/signature_json.py 95.3% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e3476...5dfa973. Read the comment docs.

@luizirber luizirber force-pushed the refactor/sourmash_lib branch from 9f6b09e to 5dfa973 Compare April 11, 2017 02:32
@betatim
Copy link
Contributor

betatim commented Apr 11, 2017

LGTM, modulo @ctb's comments about not wanting this change. I don't have a strong opinion either way.

@ctb
Copy link
Contributor

ctb commented Apr 11, 2017 via email

@luizirber luizirber changed the title Rename sourmash_lib to sourmash [RFC] Rename sourmash_lib to sourmash May 31, 2017
@luizirber luizirber mentioned this pull request Nov 15, 2017
5 tasks
@luizirber luizirber closed this Nov 15, 2017
@luizirber
Copy link
Member Author

See #374 for updated PR

@luizirber luizirber deleted the refactor/sourmash_lib branch February 19, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants