Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update authors in setup.cfg #1358

Merged
merged 2 commits into from
Mar 2, 2021
Merged

[MRG] update authors in setup.cfg #1358

merged 2 commits into from
Mar 2, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 2, 2021

this PR puts all of the authors in #622 into setup.cfg / PyPI authors list, and sets maintainers to be me and @luizirber, per #444 (comment).

Fixes #444
Fixes #622

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb added the 4.0 issues to address for a 4.0 release label Mar 2, 2021
@ctb
Copy link
Contributor Author

ctb commented Mar 2, 2021

ready for review @luizirber

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1358 (ad9c146) into latest (e15c9ea) will increase coverage by 5.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1358      +/-   ##
==========================================
+ Coverage   88.80%   94.11%   +5.30%     
==========================================
  Files         123       96      -27     
  Lines       18207    14593    -3614     
  Branches     1405     1405              
==========================================
- Hits        16169    13734    -2435     
+ Misses       1800      621    -1179     
  Partials      238      238              
Flag Coverage Δ
python 94.11% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/tests/minhash.rs
src/core/src/index/linear.rs
src/core/src/sketch/minhash.rs
src/core/src/index/bigsi.rs
src/core/src/from.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/index/mod.rs
src/core/src/signature.rs
src/core/src/lib.rs
src/core/src/sketch/hyperloglog/mod.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15c9ea...ad9c146. Read the comment docs.

@ctb ctb merged commit 1e187a5 into latest Mar 2, 2021
@ctb ctb deleted the add/authors branch March 2, 2021 17:36
@ctb
Copy link
Contributor Author

ctb commented Mar 2, 2021

thanks!

@taylorreiter
Copy link
Contributor

Can I be added too?

@ctb
Copy link
Contributor Author

ctb commented Mar 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update author list for 4.0 update authors in setup.py etc.
3 participants