Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ijson breaking change in 2.5 #737

Closed
luizirber opened this issue Sep 24, 2019 · 2 comments
Closed

ijson breaking change in 2.5 #737

luizirber opened this issue Sep 24, 2019 · 2 comments
Labels

Comments

@luizirber
Copy link
Member

luizirber commented Sep 24, 2019

FYI: ijson 2.5 breaks our tests (master is currently broken).

I'm pinning it in 2d0e297, but need to investigate a more permanent fix (or drop ijson and do the parsing in Rust, wink wink).

Relevant issue: ICRAR/ijson#13

@ctb
Copy link
Contributor

ctb commented Jul 18, 2020

so, we're not actually using ijson anywhere any more. But it's in the docs...

% git grep ijson
README.md:requirements are screed and ijson, together with a Rust environment (for the
doc/developer.md:requirements are screed and ijson, together with a Rust environment (for the
doc/release.md:python -m pip install screed pytest numpy matplotlib scipy khmer ijson bam2fasta deprecation cffi
tests/test_deprecated.py:    # ijson requires a file in binary mode or bytes,

@ctb
Copy link
Contributor

ctb commented Aug 3, 2020

removing from docs in #1140, but in any case this issue is no longer relevant :)

@ctb ctb closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants