Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a faster json library in lca/lca_db.py #1111

Closed
ctb opened this issue Jul 18, 2020 · 2 comments · Fixed by #1808
Closed

use a faster json library in lca/lca_db.py #1111

ctb opened this issue Jul 18, 2020 · 2 comments · Fixed by #1808

Comments

@ctb
Copy link
Contributor

ctb commented Jul 18, 2020

perhaps one reason LCA databases are so slow is that we're using a slow JSON parser - the stdlib one!

ref #948 #909 and oddly #737

@luizirber
Copy link
Member

perhaps one reason LCA databases are so slow is that we're using a slow JSON parser - the stdlib one!

orjson and rapidjson seem to be good drop-in replacements. hyperjson uses Rust underneath. rapidjson is in conda-forge already.
https://pythonspeed.com/articles/faster-json-library/

Or we could implement saving/loading in Rust... =]

@ctb
Copy link
Contributor Author

ctb commented Apr 16, 2022

I suspect that #1808 is going to be the best solution here - simply move to sqlite :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants