TwinagleException includes error code in message #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmtaylor
reviewed
Sep 29, 2023
runtime/src/test/scala/com/soundcloud/twinagle/TwinagleExceptionSpec.scala
Outdated
Show resolved
Hide resolved
runtime/src/main/scala/com/soundcloud/twinagle/TwinagleException.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Christopher Taylor <[email protected]>
bscherlein
force-pushed
the
TwinagleException-include-error-code-in-message
branch
from
df0cdaf to
5c4989d
Compare
ccmtaylor
deleted the
TwinagleException-include-error-code-in-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
TwinagleExceptionis used as aRuntimeException, themessageshould still show theerrorCodebecause often this has the most important information encoded.This came up for me because spec2's
ExceptionMatcheronly verifies equality of type and of message, but it might also be relevant in other contexts.Wrt releasing and semantic versioning, I think in edge cases this change could break clients if they parse the
messageto decide what to do next and look for equality of the strings.