Implement Twirp protocol v7 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* modify mapping in HTTP server * client: generate correct code for 429s from intermediaries
|
let's preserve the commits when merging this. They're separate changes, but I chose to group them in this PR. |
dziemba
reviewed
Nov 10, 2020
| ) { | ||
|
|
||
| def register[T: AsProtoService](svc: T): ServerBuilder = { | ||
| val protoService = implicitly[AsProtoService[T]].asProtoService(svc) | ||
| this.copy(endpoints = endpoints ++ protoService.rpcs) | ||
| } | ||
|
|
||
| def withPrefix(prefix: String): ServerBuilder = { | ||
| require(prefix.startsWith("/"), "prefix must start with slash") | ||
| require(!prefix.endsWith("/"), "prefix must not end with slash") |
There was a problem hiding this comment.
Should we move these checks out of this method? Otherwise I can just do ServerBuilder(prefix = "badpath/") or similar and the validation won't catch it.
dziemba
approved these changes
Nov 10, 2020
* add parameter with default value "/twirp" to - ServerBuilder constructor - generated client constructors - generated `MyService.server()` method * breaking change: remove EndpointMetadata.path method the method didn't actually represent the HTTP path anymore, so it didn't make sense.
Upstream Twirp recomends this behaviour to reduce confusion. This is fully backwards-compatible. See-Also: twitchtv/twirp#271
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/twirpHTTP path prefix configurablefixes #181.