fix: auto merge not running when there's no conflicts #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch and thanks for the contribution! I'll merge this shortly and will release a new version. |
|
Thank you! Confirmed working on my end now 👏 |
|
Good to hear, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Thank you for the great tool - highly appreciated!
I just bumped our Github Actions version, and quickly figured out that auto merging isn't working for us anymore. I tried figuring out what was going on, and we don't have any
Auto merge:. I found this, and it seems like the logic is incorrect here.Disclaimer: I haven't tested this, but it looks fairly trivial.