Rename sonic_ssd to sonic_storage matching corresponding sonic-platform-common change #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
May 22, 2024
This was referenced May 22, 2024
prgeor
previously approved these changes
May 29, 2024
|
@assrinivasan build failing |
Hi Prince, this will pass as soon as sonic-platform-common PR is merged. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
previously approved these changes
May 31, 2024
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/easycla |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… module hiding" This reverts commit 28db41d.
prgeor
approved these changes
Jun 3, 2024
maipbui
reviewed
Jun 5, 2024
arfeigin
pushed a commit
to arfeigin/sonic-utilities
that referenced
this pull request
Jun 16, 2024
…rm-common change (sonic-net#3334) * Renamed sonic_ssd to sonic_storage matching corresponding sonic-platform-common change * Added ssdutil UT * Flake8 test recommendations fixed * Workaround for circular dependency * Made ssdutil UT backwards compatible * Flake8 test fixes * More flake8 fixes * Test failure fix * Filled out init files in mocked libs to prevent unintentional module hiding * Revert "Filled out init files in mocked libs to prevent unintentional module hiding" This reverts commit 28db41d. * Forced mock of sonic_storage * Removed unused files and code * Dialed back the aggressive mocking of argparse module * Fixed flake8 test issues * Cleaned up ssdutil code and UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Renamed
sonic_ssdtosonic_storagein the ssdutil utility, matching corresponding sonic-platform-common changeHow to verify it
On an image with this change, call
sudo ssdutil-- it will not error out:Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)