Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONIC CLI for CLI-Sessions feature #3175

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

i-davydenko
Copy link
Contributor

@i-davydenko i-davydenko commented Feb 22, 2024

HLD: sonic-net/SONiC#1367

Module name PR state context
sonic-buildimage Dev cli sessions GitHub issue/pull request detail GitHub pull request check contexts
sonic-host-services cli-sessions GitHub issue/pull request detail GitHub pull request check contexts
sonic-utilities SONIC CLI for CLI-Sessions feature #3175 GitHub issue/pull request detail GitHub pull request check contexts

What I did

Implement next commands for CLI-sessions feature:

  • config serial-console inactivity-timeout

  • config serial-console sysrq-capabilities

  • show serial-console

  • config ssh max-sessions

  • config ssh inactivity-timeout

  • show ssh

How I did it

Write handlers in config/main.py for serial-console and ssh commands to cover configuration set;
Write handlers in show/main.py for serial-console and ssh to cover show commands.

How to verify it

Manual tests

Previous command output (if the output of a command-line utility has changed)

n/a

New command output (if the output of a command-line utility has changed)

n/a

config/main.py Outdated

@ssh.command('max-sessions')
@click.argument('max-sessions', metavar='<max-sessions>', required=True,
type=click.IntRange(0,100))
Copy link
Contributor

@qiluo-msft qiluo-msft Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100

Why picking this value? I could not see it in yang model. #Closed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabelmsft Please help check parameter validation logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qiluo-msft
qiluo-msft previously approved these changes May 13, 2024
@qiluo-msft
Copy link
Contributor

qiluo-msft commented May 15, 2024

Please resolve conflicts. #Closed

@i-davydenko i-davydenko force-pushed the dev-cli-sessions branch 12 times, most recently from b4572f1 to 209438b Compare May 28, 2024 10:35
@i-davydenko
Copy link
Contributor Author

/azpw run Azure.sonic-utilities

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fastiuk fastiuk closed this May 30, 2024
@fastiuk fastiuk reopened this May 30, 2024
@fastiuk fastiuk closed this Jun 3, 2024
@fastiuk fastiuk reopened this Jun 3, 2024
@fastiuk
Copy link
Contributor

fastiuk commented Aug 28, 2024

@qiluo-msft , you approved all the rest. Could you please approve that one?

@qiluo-msft qiluo-msft merged commit ed62489 into sonic-net:master Sep 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants