-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONIC CLI for CLI-Sessions feature #3175
Conversation
config/main.py
Outdated
|
||
@ssh.command('max-sessions') | ||
@click.argument('max-sessions', metavar='<max-sessions>', required=True, | ||
type=click.IntRange(0,100)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isabelmsft Please help check parameter validation logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiluo-msft upper limit for this config is specified in HLD and in yang models, please take a look:
https://github.com/sonic-net/sonic-buildimage/pull/17623/files#diff-7202f7348dad4b5be36f441f7ff0a5d6468395cbf89a9b75aa87399cef07292dR2598
Please resolve conflicts. #Closed |
a5f9308
to
103f903
Compare
b4572f1
to
209438b
Compare
209438b
to
9eda124
Compare
/azpw run Azure.sonic-utilities |
/AzurePipelines run Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
@qiluo-msft , you approved all the rest. Could you please approve that one? |
HLD: sonic-net/SONiC#1367
What I did
Implement next commands for CLI-sessions feature:
config serial-console inactivity-timeout
config serial-console sysrq-capabilities
show serial-console
config ssh max-sessions
config ssh inactivity-timeout
show ssh
How I did it
Write handlers in config/main.py for serial-console and ssh commands to cover configuration set;
Write handlers in show/main.py for serial-console and ssh to cover show commands.
How to verify it
Manual tests
Previous command output (if the output of a command-line utility has changed)
n/a
New command output (if the output of a command-line utility has changed)
n/a