-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routed subinterface enhancements #1821
Conversation
format Update "show subniterface status" to reflect subinterface in user configured long name and short name format.
This pull request introduces 3 alerts when merging 88bae6d into f76f672 - view on LGTM.com new alerts:
|
Can you add unit test? |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
||
full_intf_table_name = "INTF_TABLE" + ":" + sub_intf_name | ||
|
||
if status_type == "vlan": | ||
vlan_id = appl_db.get(appl_db.APPL_DB, full_intf_table_name, status_type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can we find DB migrator change to populate vlan_id field from sub-interface name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per updated design, intfmgrd supports both short name and long name format subinterfaces.
In long name format, vlan_id is derived from subinterface index by intfmgrd.
In short name format, vlan_id is mandatory parameter to be configured by user(as part of click cli).
With this design we do not need db_migrator changes.
sub_intf_sep_idx = subintf.find(VLAN_SUB_INTERFACE_SEPARATOR) | ||
if sub_intf_sep_idx == -1: | ||
continue | ||
if parent_intf == subintf[:sub_intf_sep_idx]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please put these new Click commands in this PR description for easy reference? also, hope you are planning to update the Click config guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@preetham-singh , can you check if the failure is related to the PR? |
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 1821 in repo Azure/sonic-utilities |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
*CLI based on Routed subinterface enhancements HLD #833 *Added support for configuring routed subinterface in short name and long name format *Updated show command to display user configured subinterfaces in correct format.
What I did
Routed subinterfae enhancements HLD #833
Added support for configuring routed subinterface in short name and long name format
Updated show command to display user configured subinterfaces in correct format.
Config commands:
config subinterface (add | del) <subinterface_name> [vlan <1-4094>]
Ex:
config subinterface add Ethernet0.100
config subinterface add Eth64.100 100
Show commands:
show subinterfaces status
How I did it
How to verify it
Configure routed subinterface on physical & port channel interfaces.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Dependency
This PR is dependent on sonic-buildimage 8761