Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[acl-loader]: Add support for handling control plane ACLs #172

Merged
merged 4 commits into from
Dec 20, 2017
Merged

[acl-loader]: Add support for handling control plane ACLs #172

merged 4 commits into from
Dec 20, 2017

Conversation

jleveque
Copy link
Contributor

  • Also a few other minor tweaks/cleanup

@jleveque jleveque self-assigned this Dec 15, 2017
@jleveque jleveque requested a review from lguohan December 15, 2017 00:54
@jleveque jleveque mentioned this pull request Dec 15, 2017
Merged
@jleveque jleveque merged commit 6710219 into sonic-net:master Dec 20, 2017
@jleveque jleveque deleted the ctrl_plane_acls branch December 20, 2017 19:42
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
@Junchao-Mellanox
[thermalctld] No need exit thermalcltd when loading invalid policy fi…
eff5c1c 
…le (sonic-net#172)

Currently, when thermalctld loading an invalid policy file, it catches the exception and call sys.exit. However, there is a sub process created and sys.exit cause the daemon hang forever. Actually, it is not necessary to exit thermalctld here because:

1. Other than running thermal policy, there is a sub process which monitoring thermal status. So even if there is an invalid policy file, thermal monitoring can still work.
2. Even if we exit here, supervisord will restart thermalctld and it fall into the same exception again and again.
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@abdosi
[submodule update] sonic-platform-common
1a62cd2 
0b9429d032c2c0449dfeaad07542707f78b5c01f (HEAD -> 201911, origin/201911)
[sfputilhelper] Add new option in ports cache creation, fetch ports from config DB (#5892) (sonic-net#172)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
acl-loader/aclshow Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @lguohan