Added PSU CLI #152
Merged
Added PSU CLI #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Nov 20, 2017
psuutil/main.py
Outdated
|
|
||
| SYSLOG_IDENTIFIER = "psuutil" | ||
| PLATFORM_SPECIFIC_MODULE_NAME = "psuutil" | ||
| PLATFORM_SPECIFIC_CLASS_NAME = "PSUutil" |
There was a problem hiding this comment.
Suggest changing case of class name to PsuUtil to match CamelCase of SfpUtil
psuutil/main.py
Outdated
| # 'numpsus' subcommand | ||
| @cli.command() | ||
| def numpsus(): | ||
| "number of supported PSU in the device" |
There was a problem hiding this comment.
Suggest "Display number of supported PSU in the device"
jleveque
reviewed
Nov 20, 2017
sonic_psu/psu_base.py
Outdated
| @@ -26,10 +26,22 @@ def get_num_psus(self): | |||
| @abc.abstractmethod | |||
| def get_psu_status(self, index): | |||
| """ | |||
| Retrieves the oprational status of power supply unit (PSU) defined | |||
| Retrieves the operational status of power supply unit (PSU) defined | |||
| by index <index> | |||
|
|
|||
| :param index: An integer, index of the PSU of which to query status | |||
| :return: Boolean, True if PSU is operating properly, False if PSU is faulty | |||
There was a problem hiding this comment.
Could you also please add more detail to my description here to reflect what we have discussed as "faulty" (e.g., if the PSU is present but powered off, it is considered a fault, and should return false.
There was a problem hiding this comment.
More details has been added
yurypm
reviewed
Nov 22, 2017
sonic_psu/psu_base.py
Outdated
| @@ -26,10 +26,22 @@ def get_num_psus(self): | |||
| @abc.abstractmethod | |||
| def get_psu_status(self, index): | |||
| """ | |||
| Retrieves the oprational status of power supply unit (PSU) defined | |||
| Retrieves the operational status of power supply unit (PSU) defined | |||
| by index <index> | |||
|
|
|||
| :param index: An integer, index of the PSU of which to query status | |||
There was a problem hiding this comment.
Is it zero-based index? I think this info should be here.
jleveque
approved these changes
Nov 27, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
sonic-net/sonic-buildimage#6768 change the kvm artifact name from kvm to vs Signed-off-by: Guohan Lu <[email protected]>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Fix errors like below:
```
admin@sonic:~$ show version
SONiC Software Version: SONiC.master.0-dirty-20201204.005739
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: 873fb969
Build date: Fri Dec 4 09:02:43 UTC 2020
Built by: user@sonic-build
Platform: x86_64-accton_wedge100bf_32x-r0
HwSKU: montara
ASIC: barefoot
Traceback (most recent call last):
File "/usr/local/bin/decode-syseeprom", line 171, in <module>
exit(main())
File "/usr/local/bin/decode-syseeprom", line 47, in main
t = class_('board', '','','')
File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 113, in __init__
if self.eeprom_init():
File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 180, in eeprom_init
self, "", [eeprom_params])
File "/usr/local/lib/python3.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 178, in set_eeprom
new_tlvs += new_tlv
TypeError: can't concat str to bytearray
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.