FRR: fix show bgp and clear bgp to provide the full set of cli options available #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync to master
rodnymolina
reviewed
Nov 15, 2017
clear/main.py
Outdated
| # Inserting BGP functionality into cli's clear parse-chain. The insertion point | ||
| # and the specific BGP commands to import, will be determined by the routing-stack | ||
| # being elected. | ||
| # Inserting BGP functionality into cli's show parse-chain. |
There was a problem hiding this comment.
Please do s/show/clear.
rodnymolina
reviewed
Nov 16, 2017
show/main.py
Outdated
| @cli.command() | ||
| @click.argument('bgp_args', nargs = -1, required = False) | ||
| def bgp(bgp_args): | ||
| bgp_cmd = "show bgp" |
There was a problem hiding this comment.
Please add a command description for both "show bgp" and "clear bgp".
We had this before for clear: """Clear BGP peers / state""" and something similar for show.
rodnymolina
approved these changes
Nov 17, 2017
lguohan
approved these changes
Nov 23, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
Configure Azure Pipelines to run unit tests on all packages, build all Python wheels and publish the test results, test coverage and resulting wheels. Note: Azure Pipelines currently has a limitation such that it does not properly support publishing multiple test coverage reports in the same pipeline. If you publish multiple test coverage reports in the same pipeline (which I am doing here), the summary and report is shown for the last task only. Any previously uploaded data is ignored. Hopefully Azure Pipelines will add support for multiple test coverage reports in the near future. See [here](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops#is-code-coverage-data-merged-when-multiple-files-are-provided-as-input-to-the-task-or-multiple-tasks-are-used-in-the-pipeline) for more info.
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Close EEPROM lock file after unlocking. Python 3 now outputs warnings such as the following to stderr if a file descriptor is left open: ``` /usr/local/bin/decode-syseeprom:171 : ResourceWarning : unclosed file <_io.TextIOWrapper name='/var/run/hw-management/eeprom/vpd_info' mode='r' encoding='UTF-8'> ``` With this change, the above warning is no longer displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.